feat!: BREAKING CHANGE - added max files limit (#685)

Author: bishalbera

src/main/java/io/kestra/plugin/aws/s3/Download.java

@@ -113,10 +113,11 @@ public class Download extends AbstractS3Object implements RunnableTask<Download.
     )
     protected Property<String> regexp;
 
+    @Builder.Default
     @Schema(
         title = "The maximum number of files to retrieve at once"
     )
-    private Property<Integer> maxFiles;
+    private Property<Integer> maxFiles = Property.ofValue(25);
 
     @Schema(
         title = "The account ID of the expected bucket owner",

src/main/java/io/kestra/plugin/aws/s3/Downloads.java

@@ -92,10 +92,11 @@ public class Downloads extends AbstractS3Object implements RunnableTask<Download
     @Builder.Default
     protected final Property<Filter> filter = Property.ofValue(Filter.BOTH);
 
+    @Builder.Default
     @Schema(
         title = "The maximum number of files to retrieve at once"
     )
-    private Property<Integer> maxFiles;
+    private Property<Integer> maxFiles = Property.ofValue(25);
 
     private Property<ActionInterface.Action> action;
 

src/main/java/io/kestra/plugin/aws/s3/List.java

@@ -66,10 +66,11 @@ public class List extends AbstractS3Object implements RunnableTask<List.Output>,
 
     protected Property<String> regexp;
 
+    @Builder.Default
     @Schema(
         title = "The maximum number of files to retrieve at once"
     )
-    private Property<Integer> maxFiles;
+    private Property<Integer> maxFiles = Property.ofValue(25);
 
     @Builder.Default
     protected final Property<Filter> filter = Property.ofValue(Filter.BOTH);
@@ -89,8 +90,8 @@ public Output run(RunContext runContext) throws Exception {
                 runContext.render(prefix).as(String.class).orElse(null)
             );
 
-            Integer rMaxFiles = runContext.render(this.maxFiles).as(Integer.class).orElse(null);
-            if (rMaxFiles != null && list.size() > rMaxFiles) {
+            int rMaxFiles = runContext.render(this.maxFiles).as(Integer.class).orElse(25);
+            if (list.size() > rMaxFiles) {
                 runContext.logger().warn(
                     "Listing returned {} files but maxFiles limit is {}. Only the first {} files will be returned. " +
                     "Increase the maxFiles property if you need more files.",

src/main/java/io/kestra/plugin/aws/s3/Trigger.java

@@ -166,10 +166,11 @@ public class Trigger extends AbstractTrigger implements PollingTriggerInterface,
     @Builder.Default
     private final Property<On> on = Property.ofValue(On.CREATE_OR_UPDATE);
 
+    @Builder.Default
     @Schema(
         title = "The maximum number of files to retrieve at once"
     )
-    private Property<Integer> maxFiles;
+    private Property<Integer> maxFiles = Property.ofValue(25);
 
     private Property<String> stateKey;
 

src/test/java/io/kestra/plugin/aws/s3/ListTest.java

@@ -106,22 +106,22 @@ void maxFilesNotExceeded() throws Exception {
     }
 
     @Test
-    void maxFilesNotSpecified() throws Exception {
+    void maxFilesDefault() throws Exception {
         this.createBucket();
 
         String dir = IdUtils.create();
 
-        // Upload 30 files
+        // Upload 30 files (more than default limit of 25)
         for (int i = 0; i < 30; i++) {
             upload("/tasks/s3/" + dir);
         }
 
-        // List WITHOUT specifying maxFiles - should return all files (no default limit)
+        // List WITHOUT specifying maxFiles - should use default of 25 and return first 25 files
         List task = list()
             .prefix(Property.ofValue("/tasks/s3/" + dir))
             .build();
         List.Output run = task.run(runContext(task));
 
-        assertThat(run.getObjects().size(), is(30));
+        assertThat(run.getObjects().size(), is(25));
     }
 }