refactor(invoke): replace @slf4j with runContext.logger() (#660)

* refactor(invoke): replace @slf4j with runContext.logger()

* test: add logger mock to fix NPE in invoke tests

Author: KarthikReddyMaru

src/main/java/io/kestra/plugin/aws/lambda/Invoke.java

@@ -7,7 +7,6 @@
 import io.kestra.core.models.annotations.Example;
 import io.kestra.core.models.annotations.Metric;
 import io.kestra.core.models.annotations.Plugin;
-import io.kestra.core.models.annotations.PluginProperty;
 import io.kestra.core.models.executions.metrics.Counter;
 import io.kestra.core.models.executions.metrics.Timer;
 import io.kestra.core.models.property.Property;
@@ -117,6 +116,7 @@ public Output run(RunContext runContext) throws Exception {
         var requestPayload = runContext.render(this.functionPayload).asMap(String.class, Object.class).isEmpty() ?
             null :
             runContext.render(this.functionPayload).asMap(String.class, Object.class);
+        var logger = runContext.logger();
 
         try (var lambda = client(runContext)) {
             var builder = InvokeRequest.builder().functionName(functionArn);
@@ -137,8 +137,8 @@ public Output run(RunContext runContext) throws Exception {
                 // details and throw - this will throw an exception in any case
                 handleError(functionArn, contentType, res.payload());
             }
-            if (log.isDebugEnabled()) {
-                log.debug("Lambda {} invoked successfully", functionArn);
+            if (logger.isDebugEnabled()) {
+                logger.debug("Lambda {} invoked successfully", functionArn);
             }
             Output out = handleContent(runContext, functionArn, contentType, res.payload());
             runContext.metric(Timer.of("duration", Duration.ofNanos(System.nanoTime() - start)));
@@ -201,7 +201,7 @@ void handleError(String functionArn, ContentType contentType, SdkBytes payload)
         try {
             errorPayload = payload.asUtf8String();
         } catch (UncheckedIOException e) {
-            log.warn("Lambda function respone payload cannot be read as UTF8 string: {}",
+            log.warn("Lambda function response payload cannot be read as UTF8 string: {}",
                     e.getMessage());
             errorPayload = null;
         }
@@ -223,6 +223,7 @@ void handleError(String functionArn, ContentType contentType, SdkBytes payload)
     @VisibleForTesting
     Output handleContent(RunContext runContext, String functionArn, ContentType contentType,
             SdkBytes payload) {
+        var logger = runContext.logger();
         try (var dataStream = payload.asInputStream()) {
             File tempFile = runContext.workingDir().createTempFile().toFile();
             // noinspection ResultOfMethodCallIgnored
@@ -232,8 +233,8 @@ Output handleContent(RunContext runContext, String functionArn, ContentType cont
             // Doing the same as in S3Service.download()
             runContext.metric(Counter.of("file.size", size));
             var uri = runContext.storage().putFile(tempFile);
-            if (log.isDebugEnabled()) {
-                log.debug("Lambda invokation task completed {}: response type: {}, file: `{}",
+            if (logger.isDebugEnabled()) {
+                logger.debug("Lambda invokation task completed {}: response type: {}, file: `{}",
                         functionArn, contentType, uri);
             }
             return Output.builder()

src/test/java/io/kestra/plugin/aws/lambda/InvokeUnitTest.java

@@ -1,28 +1,12 @@
 package io.kestra.plugin.aws.lambda;
 
-import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.ArgumentMatchers.eq;
-import static org.mockito.BDDMockito.given;
-import static org.mockito.Mockito.*;
-
-import java.io.ByteArrayInputStream;
-import java.io.File;
-import java.io.IOException;
-import java.net.URI;
-import java.nio.file.Files;
-import java.util.Collections;
-import java.util.Map;
-import java.util.Optional;
-
+import io.kestra.core.exceptions.IllegalVariableEvaluationException;
 import io.kestra.core.models.property.Property;
+import io.kestra.core.runners.RunContext;
 import io.kestra.core.runners.RunContextProperty;
+import io.kestra.core.runners.WorkingDir;
 import io.kestra.core.storages.Storage;
+import io.kestra.plugin.aws.lambda.Invoke.Output;
 import org.apache.http.entity.ContentType;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
@@ -33,16 +17,29 @@
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.mockito.stubbing.Answer;
-import io.kestra.core.exceptions.IllegalVariableEvaluationException;
-import io.kestra.core.runners.RunContext;
-import io.kestra.core.runners.WorkingDir;
-import io.kestra.plugin.aws.lambda.Invoke.Output;
+import org.slf4j.Logger;
 import software.amazon.awssdk.core.SdkBytes;
 import software.amazon.awssdk.http.SdkHttpResponse;
 import software.amazon.awssdk.services.lambda.LambdaClient;
 import software.amazon.awssdk.services.lambda.model.InvokeRequest;
 import software.amazon.awssdk.services.lambda.model.InvokeResponse;
 
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.nio.file.Files;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Optional;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.spy;
+
 @ExtendWith(MockitoExtension.class)
 public class InvokeUnitTest {
 
@@ -60,6 +57,9 @@ public class InvokeUnitTest {
     @Mock(strictness = Strictness.LENIENT)
     private WorkingDir workingDir;
 
+    @Mock(strictness = Strictness.LENIENT)
+    private Logger logger;
+
     private File tempFile;
 
     private String testValue;
@@ -70,6 +70,7 @@ void setUp() throws IOException, IllegalVariableEvaluationException {
         given(context.workingDir()).willReturn(workingDir);
         given(context.workingDir().createTempFile()).willReturn(Files.createTempFile("test", "lambdainvoke"));
         given(context.metric(any())).willReturn(context);
+        given(context.logger()).willReturn(logger);
         given(context.render(any(Property.class))).willAnswer(new Answer<RunContextProperty<String>>() {
             @Override
             public RunContextProperty<String> answer(InvocationOnMock invocation) throws Throwable {