Skip to content

Commit fb930c0

Browse files
chore: improve contributor guidelines
1 parent fb7e626 commit fb930c0

File tree

1 file changed

+1
-44
lines changed

1 file changed

+1
-44
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -40,47 +40,4 @@ Thank you for your contribution. ❤️ -->
4040

4141
### Contributor Checklist ✅
4242

43-
- [ ] PR Title and commits follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/)
44-
- [ ] Add a `closes #ISSUE_ID` or `fixes #ISSUE_ID` in the description if the PR relates to an opened issue.
45-
- [ ] Documentation updated (plugin docs from `@Schema` for properties and outputs, `@Plugin` with examples, `README.md` file with basic knowledge and specifics).
46-
- [ ] Setup instructions included if needed (API keys, accounts, etc.).
47-
- [ ] Prefix all rendered properties by `r` not `rendered` (eg: `rHost`).
48-
- [ ] Use `runContext.logger()` to log enough important infos where it's needed and with the best level (DEBUG, INFO, WARN or ERROR).
49-
50-
⚙️ **Properties**
51-
- [ ] Properties are declared with `Property<T>` carrier type, do **not** use `@PluginProperty`.
52-
- [ ] Mandatory properties must be annotated with `@NotNull` and checked during the rendering.
53-
- [ ] You can model a JSON thanks to a simple `Property<Map<String, Object>>`.
54-
55-
🌐 **HTTP**
56-
- [ ] Must use Kestra’s internal HTTP client from `io.kestra.core.http.client`
57-
58-
📦 **JSON**
59-
- [ ] If you are serializing response from an external API, you may have to add a `@JsonIgnoreProperties(ignoreUnknown = true)` at the mapped class level. So that we will avoid to crash the plugin if the provider add a new field suddenly.
60-
- [ ] Must use Jackson mappers provided by core (`io.kestra.core.serializers`)
61-
62-
**New plugins / subplugins**
63-
- [ ] Make sure your new plugin is configured like mentioned [here](https://kestra.io/docs/plugin-developer-guide/gradle#mandatory-configuration).
64-
- [ ] Add a `package-info.java` under each sub package respecting [this format](https://github.com/kestra-io/plugin-odoo/blob/main/src/main/java/io/kestra/plugin/odoo/package-info.java) and choosing the right category.
65-
- [ ] Every time you use `runContext.metric(...)` you have to add a `@Metric` ([see this doc](https://kestra.io/docs/plugin-developer-guide/document#document-the-plugin-metrics))
66-
- [ ] Docs don't support to have both tasks/triggers in the root package (e.g. `io.kestra.plugin.kubernetes`) and in a sub package (e.g. `io.kestra.plugin.kubernetes.kubectl`), whether it's: all tasks/triggers in the root package OR only tasks/triggers in sub packages.
67-
- [ ] Icons added in `src/main/resources/icons` in SVG format and not in thumbnail (keep it big):
68-
- `plugin-icon.svg`
69-
- One icon per package, e.g. `io.kestra.plugin.aws.svg`
70-
- For subpackages, e.g. `io.kestra.plugin.aws.s3`, add `io.kestra.plugin.aws.s3.svg`
71-
See example [here](https://github.com/kestra-io/plugin-elasticsearch/blob/master/src/main/java/io/kestra/plugin/elasticsearch/Search.java#L76).
72-
- [ ] Use `"{{ secret('YOUR_SECRET') }}"` in the examples for sensible infos such as an API KEY.
73-
- [ ] If you are fetching data (one, many or too many), you must add a `Property<FetchType> fetchType` to be able to use `FETCH_ONE`, `FETCH` and even `STORE` to store big amount of data in the internal storage.
74-
- [ ] Align the `"""` to close examples blocks with the flow id.
75-
- [ ] Update the existing `index.yaml` for the main plugin, and for each new subpackage add a metadata file named exactly after the subpackage (e.g. `s3.yaml` for `io.kestra.plugin.aws.s3`) under `src/main/resources/metadata/`, following the same schema.
76-
77-
🧪 **Tests**
78-
- [ ] Unit Tests added or updated to cover the change (using the `RunContext` to actually run tasks).
79-
- [ ] Add sanity checks if possible with a YAML flow inside `src/test/resources/flows`.
80-
- [ ] Avoid disabling tests for CI. Instead, configure a local environment whenever it's possible with `.github/setup-unit.sh` (to be set executable with `chmod +x setup-unit.sh`) (which can be executed locally and in the CI) all along with a new `docker-compose-ci.yml` file (do **not** edit the existing `docker-compose.yml`). If needed, create an executable (`chmod +x cleanup-unit.sh`) `cleanup-unit.sh` to remove the potential costly resources (tables, datasets, etc).
81-
- [ ] Provide screenshots from your QA / tests locally in the PR description. The goal here is to use the JAR of the plugin and directly test it locally in Kestra UI to ensure it integrates well.
82-
83-
📤 **Outputs**
84-
- [ ] Do not send back as outputs the same infos you already have in your properties.
85-
- [ ] If you do not have any output use `VoidOutput`.
86-
- [ ] Do not output twice the same infos (eg: a status code, an error code saying the same thing...).
43+
- [ ] I have read and followed the [plugin contribution guidelines](https://kestra.io/docs/plugin-developer-guide/contribution-guidelines)

0 commit comments

Comments
 (0)