🐛 The cake is a lie

- erb v2.2 was never compatible with Ruby 2.3

Author: pboling

Appraisals

@@ -22,6 +22,7 @@
 #    - Broken workflow indicates that a new contributor will have a bad time
 #
 appraise "unlocked_deps" do
+  gem "erb"
   eval_gemfile "modular/coverage.gemfile"
   eval_gemfile "modular/documentation.gemfile"
   eval_gemfile "modular/style.gemfile"
@@ -30,6 +31,7 @@ end
 # Used for head (nightly) releases of ruby, truffleruby, and jruby.
 # Split into discrete appraisals if one of them needs a dependency locked discretely.
 appraise "head" do
+  gem "erb"
   gem "mutex_m", ">= 0.2"
   gem "stringio", ">= 3.0"
   gem "benchmark", "~> 0.4", ">= 0.4.1"
@@ -38,64 +40,80 @@ end
 # Used for current releases of ruby, truffleruby, and jruby.
 # Split into discrete appraisals if one of them needs a dependency locked discretely.
 appraise "current" do
+  gem "erb"
   gem "mutex_m", ">= 0.2"
   gem "stringio", ">= 3.0"
 end
 
 appraise "ruby-2-3" do
+  # The cake is a lie. erb v2.2, the oldest release on RubyGems.org, was never compatible with Ruby 2.3.
+  # This means we have no choice but to use the erb that shipped with Ruby 2.3
+  # /opt/hostedtoolcache/Ruby/2.3.8/x64/lib/ruby/gems/2.3.0/gems/erb-2.2.2/lib/erb.rb:670:in `prepare_trim_mode': undefined method `match?' for "-":String (NoMethodError)
+  # spec.add_development_dependency("erb", ">= 2.2")                                  # ruby >= 2.3.0, not SemVer, old rubies get dropped in a patch.
 end
 
 appraise "ruby-2-4" do
+  gem "erb"
 end
 
 appraise "ruby-2-5" do
+  gem "erb"
 end
 
 appraise "ruby-2-6" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 appraise "ruby-2-7" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 appraise "ruby-3-0" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 appraise "ruby-3-1" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 appraise "ruby-3-2" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 appraise "ruby-3-3" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 # Only run security audit on latest Ruby version
 appraise "audit" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
 end
 
 # Only run coverage on latest Ruby version
 appraise "coverage" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
   eval_gemfile "modular/coverage.gemfile"
 end
 
 # Only run linter on latest Ruby version (but, in support of oldest supported Ruby version)
 appraise "style" do
+  gem "erb"
   gem "mutex_m", "~> 0.2"
   gem "stringio", "~> 3.0"
   eval_gemfile "modular/style.gemfile"

kettle-test.gemspec

@@ -140,7 +140,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency("stone_checksums", "~> 1.0")                      # ruby >= 2.2.0
 
   # Development tasks
-  spec.add_development_dependency("erb", ">= 2.2")                                  # ruby >= 2.3.0, not SemVer, old rubies get dropped in a patch.
+  # The cake is a lie. erb v2.2, the oldest release on RubyGems.org, was never compatible with Ruby 2.3.
+  # This means we have no choice but to use the erb that shipped with Ruby 2.3
+  # /opt/hostedtoolcache/Ruby/2.3.8/x64/lib/ruby/gems/2.3.0/gems/erb-2.2.2/lib/erb.rb:670:in `prepare_trim_mode': undefined method `match?' for "-":String (NoMethodError)
+  # spec.add_development_dependency("erb", ">= 2.2")                                  # ruby >= 2.3.0, not SemVer, old rubies get dropped in a patch.
   spec.add_development_dependency("gitmoji-regex", "~> 1.0", ">= 1.0.3")            # ruby >= 2.3.0
   spec.add_development_dependency("rake", "~> 13.0")                                # ruby >= 2.2.0
 end