Skip to content

AIOHTTP not recording json body #762

Open
@cadlagtrader

Description

@cadlagtrader

Hello - thanks for this great library !

I spotted an issue with 'data' vs 'json' in aiohttp_stubs vcr_request. When only json is present, vcrpy fails to record

The default fallback (from data to json) works when data is missing in the kwargs, but recent versions of aiohttp _request seems to have data = None when json is present (see @https://github.com/aio-libs/aiohttp/blob/40d8eb88de7674efbd6b001d04c0b91dad1f42d1/aiohttp/client.py#L375C11-L375C11)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions