`_make_vcr_request` doesn't support `async` streams

[jamesbraza]

I am using hishel for HTTP caching. hishel can inject an httpx.AsyncByteStream.

This leads to a failure with VCR.py where:

1. In stubs/httpx_stubs.py, _async_vcr_send calls _shared_vcr_send: https://github.com/kevin1024/vcrpy/blob/v7.0.0/vcr/stubs/httpx_stubs.py#L149-L150
2. _shared_vcr_send calls _make_vcr_request, which does a sync read: https://github.com/kevin1024/vcrpy/blob/v7.0.0/vcr/stubs/httpx_stubs.py#L108
3. The sync read will then throw an AssertionError due to not being a sync Iterable: https://github.com/encode/httpx/blob/0.28.1/httpx/_models.py#L473

Basically the request is, can VCR.py not use a sync read from within _async_vcr_send as it's not always compatible

[seowalex]

Hi @jamesbraza, I have a potential fix for this. Would you mind trying out my fork and letting me know if it works?

[jamesbraza]

Yeah that's a huge win 👍 🥳 . Previously I had to do custom monkey patching upon vcr.stubs.httpx_stubs._async_vcr_send, but now I can just delete it all and use @pytest.mark.vcr as normal.

I tested this via:

pip uninstall -y vcrpy
pip install git+https://github.com/seowalex/vcrpy.git

[seowalex]

No problem, I've actually been sitting on this fix for quite a long time, but your issue finally pushed me to make a PR. I'm not sure if I've covered all the edge cases, so let me know if you encounter any problems.

[jamesbraza]

I just regen'd all the cassettes in https://github.com/Future-House/ldp with your fork, it worked for me