Skip to content

Commit 508452b

Browse files
kevin1chunclaude
andcommitted
fix: code review — remove self-dependency, stale proxy refs, doc accuracy
- Remove robinhood-for-agents self-dependency from package.json - Remove unused msw devDependency - Update integration test comments from proxy to TokenStore auth - Fix SECURITY.md: session.enc → tokens.enc - Migrate biome.json schema to 2.4.10 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6cd97ea commit 508452b

File tree

5 files changed

+9
-13
lines changed

5 files changed

+9
-13
lines changed

SECURITY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ You will receive an acknowledgment within 48 hours and a detailed response withi
2323

2424
**In scope:**
2525
- Token or credential leakage
26-
- Encryption weaknesses in session storage (`~/.robinhood-for-agents/session.enc`)
26+
- Encryption weaknesses in token storage (`~/.robinhood-for-agents/tokens.enc`)
2727
- Unauthorized order execution or account access
2828
- Bypassing safety controls (blocked operations, parameter validation)
2929

python/tests/integration/test_client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
"""Integration tests — hit the real Robinhood API via the auth proxy.
1+
"""Integration tests — hit the real Robinhood API via TokenStore auth.
22
33
Prerequisites:
4-
1. Login: robinhood-for-agents login
5-
2. Proxy: robinhood-for-agents proxy
4+
1. Login: robinhood-for-agents onboard
65
76
Run: uv run pytest -m integration
87
"""

typescript/__tests__/integration/client.test.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
/**
2-
* Integration tests — hit the real Robinhood API via the auth proxy.
2+
* Integration tests — hit the real Robinhood API via TokenStore auth.
33
*
44
* Prerequisites:
5-
* 1. Login: robinhood-for-agents login
6-
* 2. Proxy: robinhood-for-agents proxy
5+
* 1. Login: robinhood-for-agents onboard
76
*
87
* Run: bun run test:integration
98
*
109
* Uses Bun's test runner (not Vitest) because Bun.secrets is needed
11-
* to load the proxy token from the OS keychain. Vitest runs in Node
12-
* where Bun.secrets is unavailable.
10+
* to load tokens from the OS keychain. Vitest runs in Node where
11+
* Bun.secrets is unavailable.
1312
*/
1413

1514
import { beforeAll, describe, expect, it } from "bun:test";
@@ -22,7 +21,7 @@ describe("integration: RobinhoodClient", () => {
2221
await client.restoreSession();
2322
});
2423

25-
it("authenticates via proxy", () => {
24+
it("authenticates via TokenStore", () => {
2625
expect(client.isLoggedIn).toBe(true);
2726
});
2827

typescript/biome.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"$schema": "https://biomejs.dev/schemas/2.4.8/schema.json",
2+
"$schema": "https://biomejs.dev/schemas/2.4.10/schema.json",
33
"linter": {
44
"enabled": true,
55
"rules": {

typescript/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,11 @@
4343
"@clack/prompts": "^1.1.0",
4444
"@modelcontextprotocol/sdk": "^1.12.0",
4545
"playwright-core": "^1.50.0",
46-
"robinhood-for-agents": "^0.6.2",
4746
"zod": "^4.3.6"
4847
},
4948
"devDependencies": {
5049
"@biomejs/biome": "^2.0.0",
5150
"@types/bun": "latest",
52-
"msw": "^2.7.0",
5351
"typescript": "^5.8.0",
5452
"vitest": "^4.0.18"
5553
},

0 commit comments

Comments
 (0)