Address code review feedback - improve test safety

Co-authored-by: kevinelliott <123112+kevinelliott@users.noreply.github.com>

Author: Copilot

internal/registry/registry_test.go

@@ -2,6 +2,7 @@ package registry
 
 import (
 	"runtime"
+	"strings"
 	"testing"
 )
 
@@ -219,48 +220,33 @@ func TestClaudePackageNameConsistency(t *testing.T) {
 			continue
 		}
 		// Check if command contains the expected package name
-		if !containsPackage(cmd, expectedPackage) {
+		if !strings.Contains(cmd, expectedPackage) {
 			t.Errorf("Install command for %s doesn't contain expected package '%s': %s", os, expectedPackage, cmd)
 		}
 		// Ensure it doesn't contain the wrong package name
 		wrongPackage := "@anthropic-ai/claude-cli"
-		if containsPackage(cmd, wrongPackage) {
+		if strings.Contains(cmd, wrongPackage) {
 			t.Errorf("Install command for %s contains incorrect package '%s': %s", os, wrongPackage, cmd)
 		}
 	}
 
 	// Verify all uninstall commands use the correct package
 	for os, cmd := range agent.Uninstall {
-		if cmd == "" || cmd[:3] == "See" { // Skip manual instructions
+		if cmd == "" || (len(cmd) >= 3 && cmd[:3] == "See") { // Skip manual instructions
 			continue
 		}
-		if !containsPackage(cmd, expectedPackage) {
+		if !strings.Contains(cmd, expectedPackage) {
 			t.Errorf("Uninstall command for %s doesn't contain expected package '%s': %s", os, expectedPackage, cmd)
 		}
 	}
 
 	// Verify all upgrade commands use the correct package
 	for os, cmd := range agent.Upgrade {
-		if cmd == "" || cmd[:3] == "See" { // Skip manual instructions
+		if cmd == "" || (len(cmd) >= 3 && cmd[:3] == "See") { // Skip manual instructions
 			continue
 		}
-		if !containsPackage(cmd, expectedPackage) {
+		if !strings.Contains(cmd, expectedPackage) {
 			t.Errorf("Upgrade command for %s doesn't contain expected package '%s': %s", os, expectedPackage, cmd)
 		}
 	}
 }
-
-// containsPackage checks if a command string contains the given package name
-func containsPackage(cmd, pkg string) bool {
-	// Simple string contains check
-	return len(cmd) >= len(pkg) && findSubstring(cmd, pkg)
-}
-
-func findSubstring(s, substr string) bool {
-	for i := 0; i <= len(s)-len(substr); i++ {
-		if s[i:i+len(substr)] == substr {
-			return true
-		}
-	}
-	return false
-}