bad memory access prevention

jackhumbert · jackhumbert · commit 5b6c567b4741 · 2025-07-22T17:26:52.000-04:00
diff --git a/src/kaleidoscope/driver/speaker/Base.h b/src/kaleidoscope/driver/speaker/Base.h
@@ -47,7 +47,7 @@ class Base {
 
   void playTune(const uint16_t *notes, const uint16_t *durations, uint8_t length);
   void playTune(std::initializer_list<uint16_t> notes, std::initializer_list<uint16_t> durations) {
-    playTune(notes.begin(), durations.begin(), notes.size());
+    playTune(notes.begin(), durations.begin(), min(notes.size(), durations.size()));
   }
   virtual void stopTune();
   virtual void update();

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class Base {`
`47`	`47`
`48`	`48`	`void playTune(const uint16_t notes, const uint16_t durations, uint8_t length);`
`49`	`49`	`void playTune(std::initializer_list<uint16_t> notes, std::initializer_list<uint16_t> durations) {`
`50`		`- playTune(notes.begin(), durations.begin(), notes.size());`
	`50`	`+ playTune(notes.begin(), durations.begin(), min(notes.size(), durations.size()));`
`51`	`51`	`}`
`52`	`52`	`virtual void stopTune();`
`53`	`53`	`virtual void update();`