Skip to content

Commit 8db2812

Browse files
committed
Fix variable references
Signed-off-by: Evy Bongers <[email protected]>
1 parent 8df6829 commit 8db2812

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

plugins/Kaleidoscope-Colormap-Overlay/src/kaleidoscope/plugin/Colormap-Overlay.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@ EventHandlerResult ColormapOverlay::onFocusEvent(const char *input) {
9393
return EventHandlerResult::OK;
9494

9595
if (::Focus.isEOL()) {
96-
for (uint8_t layer = 0; layer < defaultcolormap::colormap_layers; layer++) {
97-
for (int8_t i = 0; i < Runtime.device().numKeys(); i++) {
96+
for (uint8_t layer = 0; layer < layer_count; layer++) {
97+
for (int8_t key_index_ = 0; key_index_ < Runtime.device().numKeys(); key_index_++) {
98+
KeyAddr k = KeyAddr(key_index_);
9899
for (uint8_t overlay_index{0}; overlay_index < overlay_count_; ++overlay_index) {
99100
Overlay overlay = overlays_[overlay_index];
100-
if ((overlay.addr == k) && (overlay.layer == top_layer)) {
101+
if ((overlay.addr == k) && (overlay.layer == layer)) {
101102
::Focus.send(overlay.palette_index);
102103
}
103104
}

plugins/Kaleidoscope-Colormap-Overlay/src/kaleidoscope/plugin/Colormap-Overlay.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ class ColormapOverlay : public kaleidoscope::Plugin {
5858
void configureOverlays(uint8_t **overlays) {
5959
overlays_ = nullptr;
6060
overlay_count_ = 0;
61-
for (int layer_ = 0; layer_ < _layer_count; layer_++) {
62-
for (int key_index_ = 0; key_index_ < kaleidoscope_internal::device.matrix_rows * kaleidoscope_internal::device.matrix_columns; key_index_++) {
61+
for (uint8_t layer_ = 0; layer_ < _layer_count; layer_++) {
62+
for (uint8_t key_index_ = 0; key_index_ < kaleidoscope_internal::device.matrix_rows * kaleidoscope_internal::device.matrix_columns; key_index_++) {
6363
int8_t color_index_ = overlays[layer_][key_index_];
6464
if (color_index_ >= 0 && color_index_ < ::LEDPaletteTheme.getPaletteSize() &&
6565
color_index_ != no_color_overlay) {

0 commit comments

Comments
 (0)