Fix clippy warnings project-wide

Signed-off-by: Sergio Correia <[email protected]>

Author: sergio-correia

keylime-push-model-agent/src/attestation.rs

@@ -125,7 +125,7 @@ impl AttestationClient {
 
         let req = filler.get_attestation_request();
         if let Ok(json_str) = serde_json::to_string(&req) {
-            debug!("Request body: {}", json_str);
+            debug!("Request body: {json_str}");
         }
 
         let request_builder = self.client.get_json_request_from_struct(
@@ -182,7 +182,7 @@ impl AttestationClient {
                 &headers,
                 Some(config.url),
             ) {
-                warn!("201 Created response validation failed: {}", e);
+                warn!("201 Created response validation failed: {e}");
                 // Don't fail the request, just log the warning for now
             }
         }
@@ -505,8 +505,7 @@ mod tests {
             location.starts_with("http://")
                 || location.starts_with("https://")
                 || location.starts_with("/"),
-            "Location header should be a valid URI reference: {}",
-            location
+            "Location header should be a valid URI reference: {location}"
         );
 
         // Test evidence submission with RFC-compliant Location header
@@ -554,8 +553,7 @@ mod tests {
                     // Evidence submission failure is acceptable for this test
                     // We're primarily testing RFC compliance validation
                     info!(
-                        "Evidence submission failed (expected with mock): {}",
-                        e
+                        "Evidence submission failed (expected with mock): {e}"
                     );
                 }
             }

keylime-push-model-agent/src/header_validation.rs

@@ -25,10 +25,10 @@ impl std::fmt::Display for HeaderValidationError {
                 write!(f, "Missing Location header in 201 Created response")
             }
             HeaderValidationError::InvalidLocationHeader(msg) => {
-                write!(f, "Invalid Location header value: {}", msg)
+                write!(f, "Invalid Location header value: {msg}")
             }
             HeaderValidationError::InvalidBaseUrl(msg) => {
-                write!(f, "Invalid base URL: {}", msg)
+                write!(f, "Invalid base URL: {msg}")
             }
         }
     }
@@ -55,7 +55,7 @@ impl HeaderValidator {
             )
         })?;
 
-        debug!("Validating Location header: {}", location_str);
+        debug!("Validating Location header: {location_str}");
 
         // Use the existing resolve_url function for all URL validation and resolution
         if let Some(base_url) = expected_base_url {

keylime-push-model-agent/src/main.rs

@@ -116,9 +116,9 @@ fn create_registrar_tls_config<T: PushModelConfigTrait>(
     let client_key = config.registrar_tls_client_key();
 
     info!("Registrar TLS enabled: true");
-    debug!("Registrar CA certificate: {}", ca_cert);
-    debug!("Registrar client certificate: {}", client_cert);
-    debug!("Registrar client key: {}", client_key);
+    debug!("Registrar CA certificate: {ca_cert}");
+    debug!("Registrar client certificate: {client_cert}");
+    debug!("Registrar client key: {client_key}");
 
     // Only use TLS if all certificate paths are provided
     if !ca_cert.is_empty()
@@ -147,8 +147,7 @@ fn create_registrar_tls_config<T: PushModelConfigTrait>(
 
     if provided_count > 0 {
         warn!(
-            "Registrar TLS is enabled but only {} out of 3 certificate paths are configured.",
-            provided_count
+            "Registrar TLS is enabled but only {provided_count} out of 3 certificate paths are configured."
         );
         warn!("This may indicate a configuration mistake.");
         warn!(
@@ -327,7 +326,7 @@ async fn main() -> Result<()> {
 
     if let Some(user_group) = run_as {
         if let Err(e) = keylime::permissions::run_as(user_group) {
-            error!("Failed to drop privileges to {}: {}", user_group, e);
+            error!("Failed to drop privileges to {user_group}: {e}");
             error!("Troubleshooting steps:");
 
             // Provide error-specific guidance based on the error type
@@ -364,7 +363,7 @@ async fn main() -> Result<()> {
                 "Privilege dropping failed. See error messages above for troubleshooting."
             ));
         }
-        info!("Running the service as {}...", user_group);
+        info!("Running the service as {user_group}...");
     }
 
     // === CONTINUE AS UNPRIVILEGED USER ===

keylime-push-model-agent/src/struct_filler.rs

@@ -47,7 +47,7 @@ const MUTEX_POISONED_RECOVERY_MESSAGES: &[&str] = &[
 /// Helper function to log mutex poisoning recovery messages
 fn log_mutex_poisoning_recovery() {
     for msg in MUTEX_POISONED_RECOVERY_MESSAGES {
-        error!("{}", msg);
+        error!("{msg}");
     }
 }