Skip to content

Commit 0dd472e

Browse files
committed
log k8s get errors and return early
Signed-off-by: Joe McGuire <[email protected]>
1 parent b2f92e0 commit 0dd472e

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

internal/kgateway/agentgatewaysyncer/nack/publisher.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,18 @@ func newPublisher(client kube.Client) *Publisher {
4848
// onNack publishes a NACK event as a k8s event.
4949
func (p *Publisher) onNack(ctx context.Context, event NackEvent) {
5050
var gatewayUID, deployUID types.UID
51-
if gw, err := p.client.GatewayAPI().GatewayV1().Gateways(event.Gateway.Namespace).Get(ctx, event.Gateway.Name, metav1.GetOptions{}); err == nil {
52-
gatewayUID = gw.GetUID()
51+
gw, err := p.client.GatewayAPI().GatewayV1().Gateways(event.Gateway.Namespace).Get(ctx, event.Gateway.Name, metav1.GetOptions{})
52+
if err != nil {
53+
log.Error("failed to get gateway", "error", err)
54+
return
5355
}
54-
if dep, err := p.client.Kube().AppsV1().Deployments(event.Gateway.Namespace).Get(ctx, event.Gateway.Name, metav1.GetOptions{}); err == nil {
55-
deployUID = dep.GetUID()
56+
gatewayUID = gw.GetUID()
57+
dep, err := p.client.Kube().AppsV1().Deployments(event.Gateway.Namespace).Get(ctx, event.Gateway.Name, metav1.GetOptions{})
58+
if err != nil {
59+
log.Error("failed to get deployment", "error", err)
60+
return
5661
}
62+
deployUID = dep.GetUID()
5763

5864
gatewayRef := &corev1.ObjectReference{
5965
Kind: wellknown.GatewayKind,

0 commit comments

Comments
 (0)