Skip to content

Commit 2c9324b

Browse files
authored
Replace hack/krtequals with standalone krtequals module (#13091)
Signed-off-by: timflannagan <[email protected]>
1 parent 37186d7 commit 2c9324b

File tree

11 files changed

+3
-414
lines changed

11 files changed

+3
-414
lines changed

.custom-gcl.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: v2.7.1
22
name: golangci-lint-custom
33
destination: _output
44
plugins:
5-
- module: github.com/kgateway-dev/kgateway/v2/hack/krtequals
6-
path: ./hack/krtequals
5+
- module: github.com/kgateway-dev/krtequals
6+
version: 'v0.0.0-20251210234050-024ef4e99e5c'
77
- module: 'sigs.k8s.io/kube-api-linter'
88
version: 'v0.0.0-20250715075424-4fab82d26a8e' # Pin to a commit while there's no tag

.golangci.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ linters:
4040
description: Checks Equals() implementations for KRT-style semantic equality issues
4141
settings:
4242
deepEqual: false
43+
checkUnexported: false # TODO: enable this. there's several violations that need to be fixed.
4344
kubeapilinter:
4445
type: module
4546
description: Kube API Linter lints Kube like APIs based on API conventions and best practices

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ mod-download: ## Download the dependencies
121121
.PHONY: mod-tidy-nested
122122
mod-tidy-nested: ## Tidy go mod files in nested modules
123123
@echo "Tidying hack/utils/applier..." && cd hack/utils/applier && go mod tidy
124-
@echo "Tidying hack/krtequals..." && cd hack/krtequals && go mod tidy
125124

126125
.PHONY: mod-tidy
127126
mod-tidy: mod-download mod-tidy-nested ## Tidy the go mod file

hack/krtequals/analyzer.go

Lines changed: 0 additions & 295 deletions
This file was deleted.

hack/krtequals/analyzer_test.go

Lines changed: 0 additions & 25 deletions
This file was deleted.

hack/krtequals/go.mod

Lines changed: 0 additions & 13 deletions
This file was deleted.

hack/krtequals/go.sum

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)