Merge remote-tracking branch 'origin/main' into yuval-k/dev-doc

.github/actions/prep-go-runner/action.yaml

@@ -20,19 +20,45 @@ runs:
       run: |
         echo "Before clearing disk space:"
         df -h
+        docker system df -v
         
-        # https://github.com/actions/virtual-environments/issues/709
-        sudo apt-get clean
-        
+        # https://github.com/actions/runner-images/discussions/3242 github runners are bad at cleanup
+        echo "Removing large packages"
+        sudo apt-get remove -y '^dotnet-.*' || true
+        sudo apt-get remove -y '^llvm-.*' || true
+        sudo apt-get remove -y 'php.*' || true
+        sudo apt-get remove -y '^mongodb-.*' || true
+        sudo apt-get remove -y '^mysql-.*' || true
+        sudo apt-get remove -y azure-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri || true
+        sudo apt-get autoremove -y || true
+        sudo apt-get clean -y || true
+        echo "Done removing large packages"
+
         # Clean up pre-installed tools
-        # https://github.com/actions/virtual-environments/issues/1918
-        sudo rm -rf /usr/share/dotnet
-        sudo rm -rf /opt/ghc
-        sudo rm -rf /usr/local/share/boost
-        sudo rm -rf $AGENT_TOOLSDIRECTORY
+        sudo rm -rf /usr/local/lib/android || true
+        sudo rm -rf /usr/share/dotnet || true
+        sudo rm -rf /usr/local/graalvm || true
+        sudo rm -rf /opt/ghc || true
+        sudo rm -rf /usr/local/.ghcup || true
+        sudo rm -rf /usr/local/share/boost || true
+        sudo rm -rf /usr/local/share/powershell || true
+        sudo rm -rf /usr/local/share/chromium || true
+        sudo rm -rf $AGENT_TOOLSDIRECTORY || true
+
+        # Clean up images
+        docker image rm node:16 || true
+        docker image rm node:16-alpine || true
+        docker image rm node:18 || true
+        docker image rm node:18-alpine || true
+        docker image rm node:20 || true
+        docker image rm node:20-alpine || true
+        # remove the dangling images and containers
+        docker images | tail -n +2 | awk '$1 == "<none>" {print $3}' | xargs --no-run-if-empty docker rmi
+        docker ps -a | tail -n +2 | awk '$2 ~ "^[0-9a-f]+$" {print $1}' | xargs --no-run-if-empty docker rm --volumes=true
         
         echo "After clearing disk space:"
         df -h
+        docker system df -v
     - name: Set up Go
       id: setup-go
       uses: actions/setup-go@v5

.github/workflows/pr-kubernetes-tests.yaml

@@ -31,6 +31,11 @@ jobs:
         - cluster-name: 'cluster-one'
           go-test-args: '-v -timeout=25m'
           go-test-run-regex: '^TestKgateway$$/^BasicRouting$$|^TestKgateway$$/^Deployer$$|^TestKgateway$$/^HTTPRouteServices$$|^TestKgateway$$/^TCPRouteServices$$|^TestKgateway$$/^TLSRouteServices$$|^TestKgateway$$/^Backends$$'
+        # Mar 4, 2025: TODO minutes
+        - cluster-name: 'cluster-two'
+          go-test-args: '-v -timeout=25m'
+          go-test-run-regex: '^TestKgateway$$/^Transformation$$'
+
 
 #         # Dec 4, 2024: 23 minutes
 #         - cluster-name: 'cluster-two'

.github/workflows/release.yaml

@@ -39,7 +39,6 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-
       - name: Set the release related variables
         id: set_vars
         run: |
@@ -79,6 +78,9 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      - name: Prep Go Runner
+        uses: ./.github/actions/prep-go-runner
+
       - name: Helm login to ${{ env.IMAGE_REGISTRY }}
         if: ${{ github.event_name != 'pull_request' }}
         run: echo "${{ secrets.GITHUB_TOKEN }}" | helm registry login ${{ env.IMAGE_REGISTRY }} -u ${{ github.repository_owner }} --password-stdin
@@ -105,11 +107,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: "go.mod"
-          cache: true
+      - name: Prep Go Runner
+        uses: ./.github/actions/prep-go-runner
 
       # We publish a rolling main release for every commit to main. Deleting the release
       # ensures that the tagged commit is not stale. Goreleaser will create a new tag
@@ -151,10 +150,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: "go.mod"
+      - name: Prep Go Runner
+        uses: ./.github/actions/prep-go-runner
 
       - name: Login to ghcr.io
         if: ${{ github.event_name != 'pull_request' }}
@@ -173,7 +170,7 @@ jobs:
       - name: Install the released chart
         run: |
           helm install --create-namespace --namespace kgateway-system kgateway \
-            oci://${{ env.IMAGE_REGISTRY }}/kgateway-dev/charts/kgateway \
+            oci://${{ env.IMAGE_REGISTRY }}/charts/kgateway \
             --set image.registry=${{ env.IMAGE_REGISTRY }} \
             --version ${{ needs.setup.outputs.version }} \
             --wait --timeout 5m

.gitignore

@@ -59,3 +59,10 @@ istio-*/*
 .bin/
 # Added by goreleaser init:
 dist/
+
+*.o
+*.d
+*-build
+
+
+internal/envoyinit/rustformations/target/*

.goreleaser.yaml

@@ -107,8 +107,10 @@ dockers:
       - "--build-arg=GOARCH=arm64"
       - "--build-arg=ENTRYPOINT_SCRIPT=/internal/envoyinit/cmd/docker-entrypoint.sh"
       - "--build-arg=ENVOY_IMAGE={{ .Env.ENVOY_IMAGE }}"
+      - "--build-arg=RUSTFORMATIONS_DIR=/internal/envoyinit/rustformations"
     extra_files:
       - internal/envoyinit/cmd/docker-entrypoint.sh
+      - internal/envoyinit/rustformations
   - image_templates:
       - &envoyinit_amd_image "{{ .Env.IMAGE_REGISTRY }}/{{ .Env.ENVOYINIT_IMAGE_REPO }}:{{ .Env.VERSION }}-amd64"
     use: buildx
@@ -121,8 +123,10 @@ dockers:
       - "--build-arg=GOARCH=amd64"
       - "--build-arg=ENTRYPOINT_SCRIPT=/internal/envoyinit/cmd/docker-entrypoint.sh"
       - "--build-arg=ENVOY_IMAGE={{ .Env.ENVOY_IMAGE }}"
+      - "--build-arg=RUSTFORMATIONS_DIR=/internal/envoyinit/rustformations"
     extra_files:
       - internal/envoyinit/cmd/docker-entrypoint.sh
+      - internal/envoyinit/rustformations
 docker_manifests:
   - name_template: "{{ .Env.IMAGE_REGISTRY }}/{{ .Env.CONTROLLER_IMAGE_REPO }}:{{ .Env.VERSION }}"
     image_templates:

Makefile

@@ -166,6 +166,7 @@ envoyversion: ENVOY_VERSION_TAG ?= $(shell echo $(ENVOY_IMAGE) | cut -d':' -f2)
 envoyversion:
 	echo "Version is $(ENVOY_VERSION_TAG)"
 	echo "Commit for envoyproxy is $(shell curl -s https://raw.githubusercontent.com/solo-io/envoy-gloo/refs/tags/v$(ENVOY_VERSION_TAG)/bazel/repository_locations.bzl | grep "envoy =" -A 4 | grep commit | cut -d'"' -f2)"
+	echo "Current ABI in envoyinit can be found in the cargo.toml's envoy-proxy-dynamic-modules-rust-sdk"
 #----------------------------------------------------------------------------------
 # Ginkgo Tests
 #----------------------------------------------------------------------------------
@@ -312,7 +313,10 @@ generated-code: update-licenses
 generated-code: fmt
 
 .PHONY: go-generate-all
-go-generate-all: ## Run all go generate directives in the repo, including codegen for protos, mockgen, and more
+go-generate-all: go-generate-apis go-generate-mocks
+
+.PHONY: go-generate-apis
+go-generate-apis: ## Run all go generate directives in the repo, including codegen for protos, mockgen, and more
 	GO111MODULE=on go generate ./hack/...
 
 .PHONY: go-generate-mocks
@@ -459,6 +463,7 @@ envoyinit: $(ENVOYINIT_OUTPUT_DIR)/envoyinit-linux-$(GOARCH)
 
 # TODO(nfuden) cheat the process for now with -r but try to find a cleaner method
 $(ENVOYINIT_OUTPUT_DIR)/Dockerfile.envoyinit: internal/envoyinit/Dockerfile.envoyinit
+	cp  -r  ${ENVOYINIT_DIR}/rustformations $(ENVOYINIT_OUTPUT_DIR)
 	cp $< $@
 
 $(ENVOYINIT_OUTPUT_DIR)/docker-entrypoint.sh: internal/envoyinit/cmd/docker-entrypoint.sh