Skip to content

Commit 6be97df

Browse files
committed
fix matrix
Signed-off-by: John Howard <[email protected]>
1 parent 8907825 commit 6be97df

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/workflows/e2e.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ jobs:
106106
kubectl-version: ${{ steps.dotenv.outputs.kubectl_version }}
107107
istio-version: ${{ steps.dotenv.outputs.istio_version }}
108108
localstack: ${{ matrix.test.localstack }}
109+
agentgateway: ${{ matrix.test.agentgateway }}
109110
- id: run-tests
110111
uses: ./.github/actions/kubernetes-e2e-tests
111112
with:

test/e2e/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func CreateTestInstallationForCluster(
8181
// between TestInstallation outputs per CI run
8282
GeneratedFiles: MustGeneratedFiles(installContext.InstallNamespace, clusterContext.Name),
8383
}
84-
t.Cleanup(func() {
84+
testutils.Cleanup(t, func() {
8585
installation.finalize()
8686
})
8787
return installation

test/e2e/testutils/cluster/istio.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ func downloadIstio(version string) (string, error) {
198198

199199
func UninstallIstio(istioctlBinary, kubeContext string) error {
200200
// sh -c yes | istioctl uninstall —purge —context <kube-context>
201-
cmd := exec.Command("sh", "-c", fmt.Sprintf("yes | %s uninstall --purge --context %s", istioctlBinary, kubeContext)) //nolint:gosec // G204: controlled istioctl uninstall command in tests
201+
cmd := exec.Command("sh", "-c", fmt.Sprintf("yes | %s uninstall --purge --context '%s'", istioctlBinary, kubeContext)) //nolint:gosec // G204: controlled istioctl uninstall command in tests
202202
cmd.Stdout = os.Stdout
203203
cmd.Stderr = os.Stderr
204204
if err := cmd.Run(); err != nil {

0 commit comments

Comments
 (0)