testutils: Enforce CRD structural schema (#12833)

Signed-off-by: timflannagan <[email protected]>

Author: timflannagan

internal/kgateway/agentgatewaysyncer/testdata/inputs/backend/multipool-priority-levels.yaml

@@ -54,13 +54,18 @@ spec:
       - name: gemini
         gemini:
           model: "gemini-1.5-flash"
+          apiVersion: "v1"
           authToken:
             kind: "SecretRef"
             secretRef:
               name: gemini-fallback-secret
       - name: vertexai
         vertexai:
           model: "gemini-pro"
+          apiVersion: "v1"
+          location: "us-central1"
+          projectId: "vertex-fallback-project"
+          publisher: "GOOGLE"
           authToken:
             kind: "Passthrough"
     # Priority 2 - Tertiary fallback provider

internal/kgateway/agentgatewaysyncer/testdata/inputs/backend/multipool-secret-auth.yaml

@@ -45,6 +45,7 @@ spec:
       - name: gemini
         gemini:
           model: "gemini-1.5-pro"
+          apiVersion: "v1"
           authToken:
             kind: "SecretRef"
             secretRef:

internal/kgateway/agentgatewaysyncer/testdata/outputs/backend/multipool-priority-levels.yaml

@@ -15,6 +15,8 @@ Backends:
       - name: vertexai
         vertex:
           model: gemini-pro
+          projectId: vertex-fallback-project
+          region: us-central1
     - providers:
       - bedrock:
           model: anthropic.claude-3-haiku-20240307-v1:0

test/testutils/crd.go

@@ -67,12 +67,12 @@ func GetStructuralSchemas(
 func ApplyDefaults(
 	objYAML []byte,
 	structuralSchema *apiserverschema.Structural,
-) ([]byte, error) {
+) (*unstructured.Unstructured, []byte, error) {
 	// Convert YAML to map without losing any fields (using the Go type with omitempty will drop zero-value fields)
 	raw := make(map[string]interface{})
 	err := yaml.Unmarshal(objYAML, &raw)
 	if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
 	u := &unstructured.Unstructured{
 		Object: raw,
@@ -86,17 +86,17 @@ func ApplyDefaults(
 	}
 	unknownFields := structuralpruning.PruneWithOptions(u.Object, structuralSchema, true, pruneOpts)
 	if len(unknownFields) > 0 {
-		return nil, fmt.Errorf("got unknown fields: %v", unknownFields)
+		return nil, nil, fmt.Errorf("got unknown fields: %v", unknownFields)
 	}
 	structuraldefaulting.PruneNonNullableNullsWithoutDefaults(u.Object, structuralSchema)
 
 	// Apply defaults
 	structuraldefaulting.Default(u.UnstructuredContent(), structuralSchema)
 	objYAML, err = yaml.Marshal(u.Object)
 	if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
-	return objYAML, nil
+	return u, objYAML, nil
 }
 
 func parseCRDs(path string) ([]*apiextensions.CustomResourceDefinition, error) {

test/testutils/file_loader.go

@@ -13,6 +13,7 @@ import (
 
 	"github.com/ghodss/yaml"
 	apiserverschema "k8s.io/apiextensions-apiserver/pkg/apiserver/schema"
+	apiextensionsvalidation "k8s.io/apiextensions-apiserver/pkg/apiserver/validation"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -136,12 +137,17 @@ func parseFile(
 		}
 
 		if structuralSchema, ok := gvkToStructuralSchema[gvk]; ok {
-			objYamlWithDefaults, err := ApplyDefaults(objYaml, structuralSchema)
+			unstructuredObj, objYamlWithDefaults, err := ApplyDefaults(objYaml, structuralSchema)
 			if err != nil {
 				return nil, fmt.Errorf("failed to apply defaults for %s: %w", gvk, err)
 			}
-			err = yaml.Unmarshal(objYamlWithDefaults, obj)
-			if err != nil {
+			validator := apiextensionsvalidation.NewSchemaValidatorFromOpenAPI(structuralSchema.ToKubeOpenAPI())
+			validationErrs := apiextensionsvalidation.ValidateCustomResource(nil, unstructuredObj.UnstructuredContent(), validator)
+			if len(validationErrs) > 0 {
+				agg := validationErrs.ToAggregate()
+				return nil, fmt.Errorf("failed to validate %s: %w", gvk, agg)
+			}
+			if err := yaml.Unmarshal(objYamlWithDefaults, obj); err != nil {
 				return nil, fmt.Errorf("failed to unmarshal object with defaults for %s: %w", gvk, err)
 			}
 		}