put TODO for agw

puertomontt · puertomontt · commit 8f63852081d5 · 2025-12-08T15:49:57.000-06:00
Signed-off-by: omar &lt;omar.hammami@solo.io&gt;
diff --git a/pkg/kgateway/deployer/agentgateway_parameters.go b/pkg/kgateway/deployer/agentgateway_parameters.go
@@ -479,7 +479,8 @@ func (g *agentgatewayParametersHelmValuesGenerator) applyGatewayParametersToHelm
 	}
 
 	svcConfig := gwp.Spec.Kube.GetService()
-	vals.Gateway.Service = deployer.GetServiceValues(svcConfig)
+	// TODO: extract loadBalancerIP from Gateway.spec.addresses if service type is LoadBalancer
+	vals.Gateway.Service = deployer.GetServiceValues(svcConfig, nil)
 
 	svcAccountConfig := gwp.Spec.Kube.GetServiceAccount()
 	vals.Gateway.ServiceAccount = deployer.GetServiceAccountValues(svcAccountConfig)

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,8 @@ func (g *agentgatewayParametersHelmValuesGenerator) applyGatewayParametersToHelm`
`479`	`479`	`}`
`480`	`480`
`481`	`481`	`svcConfig := gwp.Spec.Kube.GetService()`
`482`		`- vals.Gateway.Service = deployer.GetServiceValues(svcConfig)`
	`482`	`+ // TODO: extract loadBalancerIP from Gateway.spec.addresses if service type is LoadBalancer`
	`483`	`+ vals.Gateway.Service = deployer.GetServiceValues(svcConfig, nil)`
`483`	`484`
`484`	`485`	`svcAccountConfig := gwp.Spec.Kube.GetServiceAccount()`
`485`	`486`	`vals.Gateway.ServiceAccount = deployer.GetServiceAccountValues(svcAccountConfig)`