wip: debug timings

Signed-off-by: John Howard <[email protected]>

Author: howardjohn

.github/actions/kubernetes-e2e-tests/action.yaml

@@ -30,6 +30,8 @@ runs:
       CLUSTER_NAME: ${{ inputs.cluster-name }}
       ISTIO_VERSION: ${{ inputs.istio-version }}
       TEST_PKG: ./test/e2e/tests
+      # Doesn't really matter, but using the same as `go build` means we can re-use the same Go cache.
+      CGO_ENABLED: 0
     shell: bash
     run: make e2e-test
   - name: Archive bug report directory on failure
@@ -38,3 +40,8 @@ runs:
     with:
       name: bug-report-${{ inputs.cluster-name }}-${{ inputs.matrix-label }}
       path: ./_test/bug_report/${{ inputs.cluster-name }}
+  - name: Upload build timings
+    uses: ./.github/actions/upload-artifact
+    with:
+      name: bug-report-${{ inputs.cluster-name }}-${{ inputs.matrix-label }}
+      path: ./_test/timings/${{ inputs.cluster-name }}

Makefile

@@ -220,7 +220,7 @@ endif
 endif
 
 # Skip -race on e2e. This requires building the codebase twice, and provides no value as the only code executed is test code.
-E2E_GO_TEST_ARGS ?= -timeout=25m -cpu=4 -outputdir=$(OUTPUT_DIR)
+E2E_GO_TEST_ARGS ?= -timeout=25m -cpu=4 -outputdir=$(OUTPUT_DIR) -debug-actiongraph=./_test/timings/$(CLUSTER_NAME)/actiongraph-test -debug-trace=./_test/timings/$(CLUSTER_NAME)/trace-test
 # Testing flags: https://pkg.go.dev/cmd/go#hdr-Testing_flags
 # The default timeout for a suite is 10 minutes, but this can be overridden by setting the -timeout flag. Currently set
 # to 25 minutes based on the time it takes to run the longest test setup (kgateway_test).
@@ -422,7 +422,7 @@ export CONTROLLER_IMAGE_REPO ?= kgateway
 # We include the files in K8S_GATEWAY_SOURCES as dependencies to the kgateway build
 # so changes in those directories cause the make target to rebuild
 $(CONTROLLER_OUTPUT_DIR)/kgateway-linux-$(GOARCH): $(K8S_GATEWAY_SOURCES)
-	$(GO_BUILD_FLAGS) GOOS=linux go build -ldflags='$(LDFLAGS)' -gcflags='$(GCFLAGS)' -o $@ ./cmd/kgateway/...
+	$(GO_BUILD_FLAGS) GOOS=linux go build -ldflags='$(LDFLAGS)' -gcflags='$(GCFLAGS)' -o $@ -debug-actiongraph=./_test/timings/$(CLUSTER_NAME)/actiongraph-build -debug-trace=./_test/timings/$(CLUSTER_NAME)/trace-build ./cmd/kgateway/...
 
 .PHONY: kgateway
 kgateway: $(CONTROLLER_OUTPUT_DIR)/kgateway-linux-$(GOARCH)

hack/kind/setup-kind.sh

@@ -33,6 +33,8 @@ LOCALSTACK="${LOCALSTACK:-false}"
 # Export the variables so they are available in the environment
 export VERSION CLUSTER_NAME
 
+mkdir -p ./_test/timings/$CLUSTER_NAME
+
 function create_kind_cluster_or_skip() {
   activeClusters=$(kind get clusters)