Working on #11966 enhancing agw backend status support

Signed-off-by: Markus Kobler <[email protected]>

Author: markuskobler

pkg/agentgateway/translator/backend_translator.go

@@ -1,12 +1,8 @@
 package translator
 
 import (
-	"github.com/agentgateway/agentgateway/go/api"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 
-	"github.com/kgateway-dev/kgateway/v2/api/v1alpha1/agentgateway"
-	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/plugins"
-	agwbackend "github.com/kgateway-dev/kgateway/v2/pkg/kgateway/agentgatewaysyncer/backend"
 	sdk "github.com/kgateway-dev/kgateway/v2/pkg/pluginsdk"
 	"github.com/kgateway-dev/kgateway/v2/pkg/pluginsdk/ir"
 )
@@ -28,11 +24,3 @@ func NewAgwBackendTranslator(extensions sdk.Plugin) *AgwBackendTranslator {
 	}
 	return translator
 }
-
-// TranslateBackend converts a BackendObjectIR to agent gateway Backend and Policy resources
-func (t *AgwBackendTranslator) TranslateBackend(
-	ctx plugins.PolicyCtx,
-	backend *agentgateway.AgentgatewayBackend,
-) ([]*api.Backend, error) {
-	return agwbackend.BuildAgwBackend(ctx, backend)
-}

pkg/kgateway/agentgatewaysyncer/backend/testdata/backend/backend-secret-not-found.yaml

@@ -0,0 +1,39 @@
+apiVersion: agentgateway.dev/v1alpha1
+kind: AgentgatewayBackend
+metadata:
+  name: openai-backend
+  namespace: default
+spec:
+  policies:
+    auth:
+      secretRef:
+        name: missing-secret
+  ai:
+    provider:
+      openai:
+        model: gpt-4
+---
+# Output
+output:
+- gateway:
+    Name: ""
+    Namespace: ""
+  resource:
+    backend:
+      ai:
+        providerGroups:
+        - providers:
+          - name: backend
+            openai:
+              model: gpt-4
+      key: default/openai-backend
+      name:
+        name: openai-backend
+        namespace: default
+status:
+  conditions:
+  - lastTransitionTime: fake
+    message: Backend successfully accepted
+    reason: Accepted
+    status: "True"
+    type: Accepted

pkg/kgateway/agentgatewaysyncer/backend/testdata/backend/backend-secret.yaml

@@ -0,0 +1,51 @@
+apiVersion: agentgateway.dev/v1alpha1
+kind: AgentgatewayBackend
+metadata:
+  name: anthropic-backend
+  namespace: default
+spec:
+  ai:
+    provider:
+      anthropic:
+        model: claude-4-5-sonnet
+  policies:
+    auth:
+      secretRef:
+        name: valid-secret
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: valid-secret
+  namespace: default
+data:
+  Authorization: QmVhcmVyIHRlc3Q=
+---
+# Output
+output:
+- gateway:
+    Name: ""
+    Namespace: ""
+  resource:
+    backend:
+      ai:
+        providerGroups:
+        - providers:
+          - anthropic:
+              model: claude-4-5-sonnet
+            name: backend
+      inlinePolicies:
+      - auth:
+          key:
+            secret: test
+      key: default/anthropic-backend
+      name:
+        name: anthropic-backend
+        namespace: default
+status:
+  conditions:
+  - lastTransitionTime: fake
+    message: Backend successfully accepted
+    reason: Accepted
+    status: "True"
+    type: Accepted

pkg/kgateway/agentgatewaysyncer/backend/translate.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	"github.com/agentgateway/agentgateway/go/api"
+	"istio.io/istio/pilot/pkg/model/kstatus"
 	"istio.io/istio/pkg/kube/krt"
 	"istio.io/istio/pkg/ptr"
 	corev1 "k8s.io/api/core/v1"
@@ -13,7 +14,9 @@ import (
 
 	apiannotations "github.com/kgateway-dev/kgateway/v2/api/annotations"
 	"github.com/kgateway-dev/kgateway/v2/api/v1alpha1/agentgateway"
+	agwir "github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/ir"
 	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/plugins"
+	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/translator"
 	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/utils"
 	"github.com/kgateway-dev/kgateway/v2/pkg/logging"
 	"github.com/kgateway-dev/kgateway/v2/pkg/utils/kubeutils"
@@ -68,6 +71,47 @@ func BuildAgwBackend(
 	return nil, errors.New("unknown backend")
 }
 
+func TranslateAgwBackend(
+	ctx plugins.PolicyCtx,
+	backend *agentgateway.AgentgatewayBackend,
+) (*agentgateway.AgentgatewayBackendStatus, []agwir.AgwResource) {
+	var results []agwir.AgwResource
+	backends, err := BuildAgwBackend(ctx, backend)
+	if err != nil {
+		logger.Error("failed to translate backend", "backend", backend.Name, "namespace", backend.Namespace, "error", err)
+		return &agentgateway.AgentgatewayBackendStatus{
+			Conditions: kstatus.UpdateConditionIfChanged(backend.Status.Conditions, metav1.Condition{
+				Type:               "Accepted",
+				Status:             metav1.ConditionFalse,
+				Reason:             "TranslationError",
+				Message:            fmt.Sprintf("failed to translate backend %v", err),
+				ObservedGeneration: backend.Generation,
+				LastTransitionTime: metav1.Now(),
+			}),
+		}, results
+	}
+	// handle all backends created as an MCPBackend backend may create multiple backends
+	for _, backend := range backends {
+		logger.Debug("creating backend", "backend", backend.Name)
+		resourceWrapper := translator.ToResourceGlobal(&api.Resource{
+			Kind: &api.Resource_Backend{
+				Backend: backend,
+			},
+		})
+		results = append(results, resourceWrapper)
+	}
+	return &agentgateway.AgentgatewayBackendStatus{
+		Conditions: kstatus.UpdateConditionIfChanged(backend.Status.Conditions, metav1.Condition{
+			Type:               "Accepted",
+			Status:             metav1.ConditionTrue,
+			Reason:             "Accepted",
+			Message:            "Backend successfully accepted",
+			ObservedGeneration: backend.Generation,
+			LastTransitionTime: metav1.Now(),
+		}),
+	}, results
+}
+
 func translateMCPBackends(ctx plugins.PolicyCtx, be *agentgateway.AgentgatewayBackend, inlinePolicies []*api.BackendPolicySpec) ([]*api.Backend, error) {
 	mcp := be.Spec.MCP
 	var mcpTargets []*api.MCPTarget

pkg/kgateway/agentgatewaysyncer/backend/translate_test.go

@@ -15,12 +15,20 @@ import (
 	"sigs.k8s.io/yaml"
 
 	"github.com/kgateway-dev/kgateway/v2/api/v1alpha1/agentgateway"
+	agwir "github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/ir"
 	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/plugins"
 	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/testutils"
 	agentgatewaybackend "github.com/kgateway-dev/kgateway/v2/pkg/kgateway/agentgatewaysyncer/backend"
 	"github.com/kgateway-dev/kgateway/v2/pkg/utils/kubeutils"
 )
 
+func TestTranslateAgwBackend(t *testing.T) {
+	testutils.RunForDirectory(t, "testdata/backend", func(t *testing.T, ctx plugins.PolicyCtx) (*agentgateway.AgentgatewayBackendStatus, []agwir.AgwResource) {
+		backend := testutils.GetTestResource(t, ctx.Collections.Backends)
+		return agentgatewaybackend.TranslateAgwBackend(ctx, backend)
+	})
+}
+
 func TestBuildMCP(t *testing.T) {
 	tests := []struct {
 		name        string

pkg/kgateway/agentgatewaysyncer/syncer.go

@@ -7,13 +7,11 @@ import (
 	"sync/atomic"
 
 	"github.com/agentgateway/agentgateway/go/api"
-	"istio.io/istio/pilot/pkg/model/kstatus"
 	"istio.io/istio/pkg/config"
 	"istio.io/istio/pkg/kube/krt"
 	"istio.io/istio/pkg/ptr"
 	"istio.io/istio/pkg/slices"
 	"istio.io/istio/pkg/util/sets"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/tools/cache"
@@ -28,6 +26,7 @@ import (
 	"github.com/kgateway-dev/kgateway/v2/pkg/agentgateway/utils"
 	"github.com/kgateway-dev/kgateway/v2/pkg/apiclient"
 	"github.com/kgateway-dev/kgateway/v2/pkg/deployer"
+	agentgatewaybackend "github.com/kgateway-dev/kgateway/v2/pkg/kgateway/agentgatewaysyncer/backend"
 	"github.com/kgateway-dev/kgateway/v2/pkg/kgateway/agentgatewaysyncer/krtxds"
 	"github.com/kgateway-dev/kgateway/v2/pkg/kgateway/agentgatewaysyncer/nack"
 	"github.com/kgateway-dev/kgateway/v2/pkg/kgateway/agentgatewaysyncer/status"
@@ -317,63 +316,20 @@ func (s *Syncer) buildListenerFromGateway(obj *translator.GatewayListener) *agwi
 	}, translator.AgwListener{l}))
 }
 
-// buildBackendFromBackendIR creates a backend resource from Backend
-func (s *Syncer) buildBackendFromBackend(ctx krt.HandlerContext, backend *agentgateway.AgentgatewayBackend) ([]agwir.AgwResource, *agentgateway.AgentgatewayBackendStatus) {
-	var results []agwir.AgwResource
-	var backendStatus *agentgateway.AgentgatewayBackendStatus
-	pc := plugins.PolicyCtx{
-		Krt:         ctx,
-		Collections: s.agwCollections,
-	}
-	backends, err := s.translator.BackendTranslator().TranslateBackend(pc, backend)
-	if err != nil {
-		logger.Error("failed to translate backend", "backend", backend.Name, "namespace", backend.Namespace, "error", err)
-		backendStatus = &agentgateway.AgentgatewayBackendStatus{
-			Conditions: kstatus.UpdateConditionIfChanged(backend.Status.Conditions, metav1.Condition{
-				Type:               "Accepted",
-				Status:             metav1.ConditionFalse,
-				Reason:             "TranslationError",
-				Message:            fmt.Sprintf("failed to translate backend %v", err),
-				ObservedGeneration: backend.Generation,
-				LastTransitionTime: metav1.Now(),
-			}),
-		}
-		return results, backendStatus
-	}
-	// handle all backends created as an MCPBackend backend may create multiple backends
-	for _, backend := range backends {
-		logger.Debug("creating backend", "backend", backend.Name)
-		resourceWrapper := translator.ToResourceGlobal(&api.Resource{
-			Kind: &api.Resource_Backend{
-				Backend: backend,
-			},
-		})
-		results = append(results, resourceWrapper)
-	}
-	backendStatus = &agentgateway.AgentgatewayBackendStatus{
-		Conditions: kstatus.UpdateConditionIfChanged(backend.Status.Conditions, metav1.Condition{
-			Type:               "Accepted",
-			Status:             metav1.ConditionTrue,
-			Reason:             "Accepted",
-			Message:            "Backend successfully accepted",
-			ObservedGeneration: backend.Generation,
-			LastTransitionTime: metav1.Now(),
-		}),
-	}
-	return results, backendStatus
-}
-
-// newADPBackendCollection creates the ADP backend collection for agent gateway resources
+// newAgwBackendCollection creates the ADP backend collection for agent gateway resources
 func (s *Syncer) newAgwBackendCollection(finalBackends krt.Collection[*agentgateway.AgentgatewayBackend], krtopts krtutil.KrtOptions) (
 	krt.StatusCollection[*agentgateway.AgentgatewayBackend, agentgateway.AgentgatewayBackendStatus],
 	krt.Collection[agwir.AgwResource],
 ) {
-	return krt.NewStatusManyCollection(finalBackends, func(krtctx krt.HandlerContext, backend *agentgateway.AgentgatewayBackend) (
+	return krt.NewStatusManyCollection(finalBackends, func(ctx krt.HandlerContext, backend *agentgateway.AgentgatewayBackend) (
 		*agentgateway.AgentgatewayBackendStatus,
 		[]agwir.AgwResource,
 	) {
-		resources, status := s.buildBackendFromBackend(krtctx, backend)
-		return status, resources
+		pc := plugins.PolicyCtx{
+			Krt:         ctx,
+			Collections: s.agwCollections,
+		}
+		return agentgatewaybackend.TranslateAgwBackend(pc, backend)
 	}, krtopts.ToOptions("Backends")...)
 }