Skip to content

Commit da11503

Browse files
Update github to trigger on ready for review (#9177)
* update github to trigger on ready for review * changelog * Trigger CI * add github action trigger for regression tests * add draft pr skip to gloo gateway tests and conformance tests * add trigger for docs gen, fix workflow README --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
1 parent 57708a4 commit da11503

File tree

5 files changed

+23
-8
lines changed

5 files changed

+23
-8
lines changed

.github/workflows/README.md

+11-6
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,26 @@ To test this on 1.13.x branch:
3535

3636
**NOTE: After the PR opens in solo-apis, we want to avoid the chance that it merges. Please put a 'work in progress' label on the PR to prevent it from merging.**
3737

38+
## [Gloo Gateway Conformance Tests](./regression-tests.yaml)
39+
Conformance tests a pinned version of the [Kubernetes Gateway API Conformance suite](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/conformance_test.go).
40+
41+
### Draft Pull Requests
42+
This Github Action will not run by default on a Draft Pull Request. After a Pull Request is marked as `Ready for Review`
43+
it will trigger the action to run.
44+
3845
## [Regression Tests](./regression-tests.yaml)
3946
Regression tests run the suite of [Kubernetes End-To-End Tests](https://github.com/solo-io/gloo/tree/main/test).
4047

4148
### Draft Pull Requests
42-
This Github Action will not run by default on a Draft Pull Request. If you would like to run this, you need to:
43-
1. Mark the PR as `Ready for Review`
44-
1. Push an empty commit to run the jobs: `git commit --allow-empty -m "Trigger CI"`
49+
This Github Action will not run by default on a Draft Pull Request. After a Pull Request is marked as `Ready for Review`
50+
it will trigger the action to run.
4551

4652
## [Docs Generation](./docs-gen.yaml)
4753
Docs generation builds the docs that power https://docs.solo.io/gloo-edge/latest/, and on pushes to the main branch, deploys those changes to Firebase.
4854

4955
### Draft Pull Requests
50-
This Github Action will not run by default on a Draft Pull Request. If you would like to run this, you need to:
51-
1. Mark the PR as `Ready for Review`
52-
1. Push an empty commit to run the jobs: `git commit --allow-empty -m "Trigger CI"`
56+
This Github Action will not run by default on a Draft Pull Request. After a Pull Request is marked as `Ready for Review`
57+
it will trigger the action to run.
5358

5459
## [Trivy Vulnerability Scanning](./trivy-analysis-scheduled.yaml)
5560
A scheduled job which scans images released from both the Open Source and Enterprise repositories.

.github/workflows/docs-gen.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ on:
1212
- 'v1.14.x'
1313
- 'v1.13.x'
1414
pull_request:
15+
types: [opened, synchronize, reopened, ready_for_review]
1516
branches:
1617
- 'main'
1718
workflow_run:

.github/workflows/pr.yaml

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
name: GGII Tests
2-
on: pull_request
2+
on:
3+
pull_request:
4+
types: [opened, synchronize, reopened, ready_for_review]
35

46
jobs:
57
test_gloo_gateway2:
68
name: Build and Test Gloo Gateway 2
79
runs-on: ubuntu-22.04
810
timeout-minutes: 10
11+
if: ${{ !github.event.pull_request.draft }}
912
steps:
1013
- uses: actions/checkout@v4
1114
- name: Setup Go 1.21
@@ -23,6 +26,7 @@ jobs:
2326
name: Run Gateway api conformance tests
2427
runs-on: ubuntu-22.04
2528
timeout-minutes: 15
29+
if: ${{ !github.event.pull_request.draft }}
2630
steps:
2731
- uses: actions/checkout@v4
2832
- name: Setup Go 1.21

.github/workflows/regression-tests.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: Regression Tests
2-
on: pull_request
2+
on:
3+
pull_request:
4+
types: [opened, synchronize, reopened, ready_for_review]
35

46
env:
57
VERSION: '1.0.0-ci'
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
changelog:
2+
- type: NON_USER_FACING
3+
description: Update Github workflow to trigger on pr opened, reopened, synchronize and ready for review.

0 commit comments

Comments
 (0)