k8s-gateway: support configurable deployer and plugin translation (#9227)

* support configurable deployer and plugin tarnslation

* add changelog

* define defaults

* PR feedback

* bad find/replace

* handle bad override, avoid npe

Author: sam-heilbron

changelog/v1.17.0-beta11/inject-enterprise-functionality.yaml

@@ -0,0 +1,9 @@
+changelog:
+  - type: NON_USER_FACING
+    issueLink: https://github.com/solo-io/solo-projects/issues/5874
+    resolvesIssue: false
+    description: >-
+      Run the PluginRegistryFactory supplied by the setup.Extensions, to ensure that the Enterprise ControlPlane
+      runs all the Enterprise plugins.
+      Create an experimental API (temporary) to configure the image used for the proxy workloads. This will be used
+      by the Enterprise ControlPlane, while the workload provisioning API is being discussed.

projects/gateway2/controller/start.go

@@ -3,6 +3,10 @@ package controller
 import (
 	"context"
 
+	v1 "github.com/solo-io/gloo/projects/gloo/pkg/api/v1"
+	"github.com/solo-io/gloo/projects/gloo/pkg/plugins"
+	"github.com/solo-io/gloo/projects/gloo/pkg/translator"
+
 	"github.com/solo-io/gloo/projects/gateway2/wellknown"
 
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
@@ -35,6 +39,12 @@ var (
 type StartConfig struct {
 	Dev          bool
 	ControlPlane bootstrap.ControlPlane
+
+	Settings *v1.Settings
+
+	// GlooPluginRegistryFactory is the factory function to produce a PluginRegistry
+	// The plugins in this registry are used during the conversion of a Proxy resource into an xDS Snapshot
+	GlooPluginRegistryFactory plugins.PluginRegistryFactory
 }
 
 // Start runs the controllers responsible for processing the K8s Gateway API objects
@@ -66,7 +76,10 @@ func Start(ctx context.Context, cfg StartConfig) error {
 	// TODO: replace this with something that checks that we have xds snapshot ready (or that we don't need one).
 	mgr.AddReadyzCheck("ready-ping", healthz.Ping)
 
-	glooTranslator := newGlooTranslator(ctx)
+	glooTranslator := translator.NewDefaultTranslator(
+		cfg.Settings,
+		cfg.GlooPluginRegistryFactory(ctx))
+
 	var sanz sanitizer.XdsSanitizers
 	inputChannels := xds.NewXdsInputChannels()
 	xdsSyncer := xds.NewXdsSyncer(

projects/gateway2/controller/translator.go

@@ -7,7 +7,11 @@ import (
 	"fmt"
 	"io"
 	"io/fs"
+	"os"
 	"path/filepath"
+	"strings"
+
+	"github.com/solo-io/gloo/projects/gloo/constants"
 
 	"github.com/solo-io/gloo/pkg/version"
 	"github.com/solo-io/gloo/projects/gateway2/helm"
@@ -150,6 +154,7 @@ func (d *Deployer) renderChartToObjects(ctx context.Context, gw *api.Gateway) ([
 				"host": fmt.Sprintf("gloo.%s.svc.%s", defaults.GlooSystem, "cluster.local"),
 				"port": d.inputs.Port,
 			},
+			"image": getDeployerImageValues(),
 		},
 	}
 	if d.inputs.Dev {
@@ -309,3 +314,26 @@ func ConvertYAMLToObjects(scheme *runtime.Scheme, yamlData []byte) ([]client.Obj
 
 	return objs, nil
 }
+
+func getDeployerImageValues() map[string]any {
+	image := os.Getenv(constants.GlooGatewayDeployerImage)
+	defaultImageValues := map[string]any{
+		// If tag is not defined, we fall back to the default behavior, which is to use that Chart version
+		"tag": "",
+	}
+
+	if image == "" {
+		// If the env is not defined, return the default
+		return defaultImageValues
+	}
+
+	imageParts := strings.Split(image, ":")
+	if len(imageParts) != 2 {
+		// If the user provided an invalid override, fallback to the default
+		return defaultImageValues
+	}
+	return map[string]any{
+		"repository": imageParts[0],
+		"tag":        imageParts[1],
+	}
+}

projects/gateway2/deployer/deployer.go

@@ -2,4 +2,11 @@ package constants
 
 const (
 	GlooGatewayEnableK8sGwControllerEnv = "GG_EXPERIMENTAL_K8S_GW_CONTROLLER"
+
+	// GlooGatewayDeployerImage is an experimental API that allows users to inject the image
+	// that the deployer should provision. The value should be in the form:
+	//	[image_repository:image_tag] --> quay.io/solo-io/gloo-envoy-wrapper:1.17.0-beta1
+	// This API is intended to be short-lived, as the long-term vision is to support a CR to define
+	// configuration for our deployer
+	GlooGatewayDeployerImage = "GG_EXPERIMENTAL_DEPLOYER_IMAGE"
 )

projects/gloo/constants/gloo_gateway.go

@@ -45,7 +45,9 @@ func ExecuteAsynchronousStartFuncs(
 func K8sGatewayControllerStartFunc() StartFunc {
 	return func(ctx context.Context, opts bootstrap.Opts, extensions Extensions) error {
 		return controller.Start(ctx, controller.StartConfig{
-			ControlPlane: opts.ControlPlane,
+			ControlPlane:              opts.ControlPlane,
+			Settings:                  opts.Settings,
+			GlooPluginRegistryFactory: extensions.PluginRegistryFactory,
 
 			// Useful for development purposes
 			// At the moment, this is not tied to any user-facing API