helm: change default registry (#10746)

Author: yuval-k

.github/actions/kube-gateway-api-conformance-tests/action.yaml

@@ -57,7 +57,7 @@ runs:
         # If matrix.version is empty, use the local chart path specified in the Makefile.
         helm upgrade -i -n kgateway-system kgateway ./install/helm/kgateway/ \
           --create-namespace \
-          --set image.tag=${VERSION}
+          --set image.tag=${VERSION} --set image.registry=ghcr.io/kgateway-dev
       else
         # TODO(tim): this will require changes once the new helm chart is integrated
         # and published with the release pipeline.

.github/workflows/release.yaml

@@ -21,6 +21,7 @@ on:
       - main
 
 env:
+  # this is uses the `github.repository_owner` to support releases from forks (useful for testing).
   IMAGE_REGISTRY: ghcr.io/${{ github.repository_owner }}
 
 permissions:
@@ -172,11 +173,9 @@ jobs:
       - name: Install the released chart
         run: |
           helm install --create-namespace --namespace kgateway-system kgateway \
-            oci://${{ env.IMAGE_REGISTRY }}/charts/kgateway \
+            oci://${{ env.IMAGE_REGISTRY }}/kgateway-dev/charts/kgateway \
+            --set image.registry=${{ env.IMAGE_REGISTRY }} \
             --version ${{ needs.setup.outputs.version }} \
-            --set controller.image.registry=${{ env.IMAGE_REGISTRY }} \
-            --set gateway.envoyContainer.image.registry=${{ env.IMAGE_REGISTRY }} \
-            --set gateway.sdsContainer.image.registry=${{ env.IMAGE_REGISTRY }} \
             --wait --timeout 5m
 
       - name: Wait for the kgateway deployment to be ready

.goreleaser.yaml

@@ -164,9 +164,9 @@ release:
 
     The docker images are available at:
 
-    - {{ .Env.IMAGE_REGISTRY }}:{{ .Env.CONTROLLER_IMAGE_REPO }}:{{ .Env.VERSION }}
-    - {{ .Env.IMAGE_REGISTRY }}:{{ .Env.SDS_IMAGE_REPO }}:{{ .Env.VERSION }}
-    - {{ .Env.IMAGE_REGISTRY }}:{{ .Env.ENVOYINIT_IMAGE_REPO }}:{{ .Env.VERSION }}
+    - cr.kgateway.dev/kgateway-dev/{{ .Env.CONTROLLER_IMAGE_REPO }}:{{ .Env.VERSION }}
+    - cr.kgateway.dev/kgateway-dev/{{ .Env.SDS_IMAGE_REPO }}:{{ .Env.VERSION }}
+    - cr.kgateway.dev/kgateway-dev/{{ .Env.ENVOYINIT_IMAGE_REPO }}:{{ .Env.VERSION }}
 
     ## Quickstart
 

Tiltfile

@@ -57,7 +57,7 @@ RUN chmod 777 ./$binary_name
 standard_entrypoint = "ENTRYPOINT /app/start.sh /app/$binary_name"
 debug_entrypoint = "ENTRYPOINT /app/start.sh /go/bin/dlv --listen=0.0.0.0:$debug_port --api-version=2 --headless=true --only-same-user=false --accept-multiclient --check-go-version=false exec --continue /app/$binary_name"
 
-get_resources_cmd = "{0} -n {1} template {2} --include-crds install/helm/kgateway/ --set image.pullPolicy='Never' --set image.tag='{3}'".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"), image_tag)
+get_resources_cmd = "{0} -n {1} template {2} --include-crds install/helm/kgateway/ --set image.pullPolicy='Never' --set image.registry=ghcr.io/kgateway-dev --set image.tag='{3}'".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"), image_tag)
 for f in settings.get("helm_values_files") :
     get_resources_cmd = get_resources_cmd + " --values=" + f
 
@@ -204,7 +204,7 @@ def install_kgateway():
     if not kgateway_installed :
         install_helm_cmd = """
             kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || {{ kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.1.0/standard-install.yaml; }} ;
-            {0} upgrade --install -n {1} --create-namespace {2} install/helm/kgateway/ --set controller.image.pullPolicy='Never' --set image.tag='{3}'""".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"), image_tag)
+            {0} upgrade --install -n {1} --create-namespace {2} install/helm/kgateway/ --set controller.image.pullPolicy='Never' --set image.registry=ghcr.io/kgateway-dev --set image.tag='{3}'""".format(helm_cmd, settings.get("helm_installation_namespace"), settings.get("helm_installation_name"), image_tag)
         for f in settings.get("helm_values_files") :
             install_helm_cmd = install_helm_cmd + " --values=" + f
         local_resource(

install/helm/kgateway/values.yaml

@@ -138,6 +138,6 @@ gateway:
     statsRoutePrefixRewrite: "/stats"
 
 image:
-  registry: ghcr.io/kgateway-dev
+  registry: cr.kgateway.dev/kgateway-dev
   tag: ""
   pullPolicy: IfNotPresent

test/kubernetes/e2e/tests/manifests/common-recommendations.yaml

@@ -10,6 +10,9 @@
 # defaults in our values-template.yaml overtime. That way, users of the product can have the easiest experience,
 # and gain the best value, without custom configuration.
 
+image:
+  registry: ghcr.io/kgateway-dev
+
 # Configuration for the kgateway controller pod
 controller:
   # we need to be able to troubleshoot failures using logs; when users encounter problems enabling debug logging is