Commit 084f222
misc: Make
Summary:
`StructColumnReader::loadRowGroup` clones the buffered input. To keep using
custom `DirectBufferedInput` after cloning, we need to override clone, which
requires changing some fields from private to protected.
https://github.com/facebookincubator/velox/blob/22b90045ef5737c737593fbedde1f6f4f64d6dc5/velox/dwio/parquet/reader/StructColumnReader.cpp#L124
Pull Request resolved: facebookincubator#16979
Reviewed By: Yuhta
Differential Revision: D99354261
Pulled By: bikramSingh91
fbshipit-source-id: 30df4d5bfb93d7217cd573f1fb0bda23c84bdbd9DirectBufferedInput clone fields protected (facebookincubator#16979)1 parent d9c1b6e commit 084f222
File tree
2 files changed
+21
-13
lines changed- velox/dwio/common
- tests
2 files changed
+21
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
242 | 250 | | |
243 | 251 | | |
244 | 252 | | |
| |||
301 | 309 | | |
302 | 310 | | |
303 | 311 | | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | 312 | | |
314 | 313 | | |
315 | 314 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
692 | 692 | | |
693 | 693 | | |
694 | 694 | | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
699 | 695 | | |
700 | 696 | | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
701 | 710 | | |
702 | 711 | | |
703 | 712 | | |
| |||
0 commit comments