Skip to content

Commit 3b1dd8b

Browse files
r-barnesfacebook-github-bot
authored andcommitted
fix: Fix unused-local-typedef issue in velox/dwio/dwrf/test/ColumnWriterTest.cpp +1 (facebookincubator#14460)
Summary: Pull Request resolved: facebookincubator#14460 LLVM has a warning `-Wunused-local-typedef` which we are enabling to remove unused code. This has the side-effect of making it easier to do refactors should as removing unnecessary includes. For questions/comments, contact r-barnes. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D79968264 fbshipit-source-id: e53a3cf03752a70d6bf4a310b306479e9725154f
1 parent 9d6a54d commit 3b1dd8b

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

velox/dwio/dwrf/test/ColumnWriterTest.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1504,10 +1504,6 @@ void testFlatMapWriter(
15041504
}
15051505

15061506
TEST_F(ColumnWriterTest, TestFlatMapKeyNotInAllBatches) {
1507-
using keyType = StringView;
1508-
using valueType = StringView;
1509-
using b = MapBuilder<keyType, valueType>;
1510-
15111507
VectorMaker maker(pool_.get());
15121508
// Test the case where not all keys appear in all batches.
15131509
const std::vector<RowVectorPtr> batches{
@@ -1522,10 +1518,6 @@ TEST_F(ColumnWriterTest, TestFlatMapKeyNotInAllBatches) {
15221518
}
15231519

15241520
TEST_F(ColumnWriterTest, TesFlatMapDuplicatedKey) {
1525-
using keyType = StringView;
1526-
using valueType = StringView;
1527-
using b = MapBuilder<keyType, valueType>;
1528-
15291521
const size_t size = 3;
15301522
const BufferPtr inMaps = AlignedBuffer::allocate<bool>(size, pool_.get());
15311523
bits::fillBits(inMaps->asMutable<uint64_t>(), 1, size, pool_.get());

0 commit comments

Comments
 (0)