Skip to content

Commit 49d5cda

Browse files
Yuhtafacebook-github-bot
authored andcommitted
fix(prism): Allow dictionary vector when loading lazy delta for FULL_REWRITE (facebookincubator#13094)
Summary: Pull Request resolved: facebookincubator#13094 In full rewrite update there is no restriction on the encoding of delta vector, so we can return the vector as it is. Reviewed By: pedroerp Differential Revision: D73373386 fbshipit-source-id: a004ed57a2011b61e7a00591d9c8d04cb985f6f8
1 parent f045b35 commit 49d5cda

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

velox/dwio/dwrf/test/utils/E2EWriterTestUtil.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ class E2EWriterTestUtil {
113113

114114
static std::vector<VectorPtr> generateBatches(VectorPtr batch);
115115

116+
/// NOTE: This will trigger flush before first write and disable dictionary
117+
/// encoding.
116118
static std::function<std::unique_ptr<DWRFFlushPolicy>()>
117119
simpleFlushPolicyFactory(bool flushPerBatch) {
118120
return [flushPerBatch]() {

0 commit comments

Comments
 (0)