Skip to content

Commit 63d30e9

Browse files
Huameng (Michael) Jiangmeta-codesync[bot]
authored andcommitted
feat(readers): Control knob in row reader option (facebookincubator#15767)
Summary: Pull Request resolved: facebookincubator#15767 See D88118026 for details on the control knob to branch on the different column reader and encoding behavior. In order for OSS build to pass, we need to first land the velox PR and then advance velox hash. Reviewed By: Yuhta Differential Revision: D89134173 fbshipit-source-id: 28541200097f7520ff1013934cf81f515c252cde
1 parent e0c1dcb commit 63d30e9

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

velox/dwio/common/Options.h

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,16 @@ class RowReaderOptions {
449449
return trackRowSize_;
450450
}
451451

452-
void setTrackRowSize(bool value) {
453-
trackRowSize_ = value;
452+
void setTrackRowSize(bool trackRowSize) {
453+
trackRowSize_ = trackRowSize;
454+
}
455+
456+
bool passStringBuffersFromDecoder() const {
457+
return passStringBuffersFromDecoder_;
458+
}
459+
460+
void setPassStringBuffersFromDecoder(bool passStringBuffersFromDecoder) {
461+
passStringBuffersFromDecoder_ = passStringBuffersFromDecoder;
454462
}
455463

456464
private:
@@ -513,6 +521,7 @@ class RowReaderOptions {
513521

514522
std::shared_ptr<FormatSpecificOptions> formatSpecificOptions_;
515523
bool trackRowSize_{false};
524+
bool passStringBuffersFromDecoder_{true};
516525
};
517526

518527
/// Options for creating a Reader.

0 commit comments

Comments
 (0)