fix(ci): Skip cancelled runs in failure reporting

When a CI run is cancelled (e.g., superseded by a newer push), status
jobs were incorrectly reporting "build failed" because the outcome was
empty/cancelled rather than success. Now all status jobs check for
cancelled state and exit cleanly without error annotations or artifact
uploads. Also updated ci-failure-comment.yml to only trigger on actual
failures, not cancelled runs.

Author: kgpai

.github/workflows/ci-failure-comment.yml

@@ -40,7 +40,7 @@ jobs:
   post-failure-comment:
     if: >
       github.event.workflow_run.event == 'pull_request' &&
-      github.event.workflow_run.conclusion != 'success'
+      github.event.workflow_run.conclusion == 'failure'
     runs-on: ubuntu-latest
     steps:
       - name: Get PR number

.github/workflows/linux-build-base.yml

@@ -328,8 +328,12 @@ jobs:
     name: "BUILD: Linux release with adapters"
     steps:
       - run: |
+          if [[ -z "$BUILD_OUTCOME" || "$BUILD_OUTCOME" == "cancelled" ]]; then
+            echo "Build was cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$BUILD_OUTCOME" != "success" ]]; then
-            echo "::error::Linux adapters release build failed or was cancelled. Do not land this PR until the build is fixed."
+            echo "::error::Linux adapters release build failed. Do not land this PR until the build is fixed."
             exit 1
           fi
           echo "Build succeeded."
@@ -366,10 +370,18 @@ jobs:
     name: "TEST: Linux release with adapters"
     steps:
       - run: |
+          if [[ -z "$BUILD_OUTCOME" || "$BUILD_OUTCOME" == "cancelled" ]]; then
+            echo "Run was cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$BUILD_OUTCOME" != "success" ]]; then
-            echo "::error::Build failed or was cancelled — tests did not run. Check the 'Linux release with adapters' build job for compiler errors and build logs."
+            echo "::error::Build failed — tests did not run. Check the 'Linux release with adapters' build job for compiler errors and build logs."
             exit 1
           fi
+          if [[ -z "$TEST_OUTCOME" || "$TEST_OUTCOME" == "cancelled" ]]; then
+            echo "Tests were cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$TEST_OUTCOME" != "success" ]]; then
             if [[ -n "$FAILED_CASES" ]]; then
               CASE_LIST=$(echo "$FAILED_CASES" | sed 's/^/  - /')
@@ -663,8 +675,12 @@ jobs:
     name: "BUILD: Ubuntu debug with system dependencies"
     steps:
       - run: |
+          if [[ -z "$BUILD_OUTCOME" || "$BUILD_OUTCOME" == "cancelled" ]]; then
+            echo "Build was cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$BUILD_OUTCOME" != "success" ]]; then
-            echo "::error::Ubuntu debug build failed or was cancelled. Do not land this PR until the build is fixed."
+            echo "::error::Ubuntu debug build failed. Do not land this PR until the build is fixed."
             exit 1
           fi
           echo "Build succeeded."
@@ -701,10 +717,18 @@ jobs:
     name: "TEST: Ubuntu debug with system dependencies"
     steps:
       - run: |
+          if [[ -z "$BUILD_OUTCOME" || "$BUILD_OUTCOME" == "cancelled" ]]; then
+            echo "Run was cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$BUILD_OUTCOME" != "success" ]]; then
-            echo "::error::Build failed or was cancelled — tests did not run. Check the 'Ubuntu debug with system dependencies' build job for compiler errors and build logs."
+            echo "::error::Build failed — tests did not run. Check the 'Ubuntu debug with system dependencies' build job for compiler errors and build logs."
             exit 1
           fi
+          if [[ -z "$TEST_OUTCOME" || "$TEST_OUTCOME" == "cancelled" ]]; then
+            echo "Tests were cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$TEST_OUTCOME" != "success" ]]; then
             if [[ -n "$FAILED_CASES" ]]; then
               CASE_LIST=$(echo "$FAILED_CASES" | sed 's/^/  - /')
@@ -881,8 +905,12 @@ jobs:
     name: "BUILD: Fedora debug"
     steps:
       - run: |
+          if [[ -z "$BUILD_OUTCOME" || "$BUILD_OUTCOME" == "cancelled" ]]; then
+            echo "Build was cancelled (likely superseded by a newer push). Skipping."
+            exit 0
+          fi
           if [[ "$BUILD_OUTCOME" != "success" ]]; then
-            echo "::error::Fedora debug build failed or was cancelled. Do not land this PR until the build is fixed."
+            echo "::error::Fedora debug build failed. Do not land this PR until the build is fixed."
             exit 1
           fi
           echo "Build succeeded."