Skip to content

Commit 7e016f4

Browse files
Krishna Paifacebook-github-bot
authored andcommitted
Skip first() in Spark aggregation fuzzer to fix CI crashes
Summary: The Spark aggregation fuzzer consistently crashes (SIGSEGV) when testing the `first` aggregate function with complex ROW-typed group-by keys in a streaming aggregation + LocalMerge + abandon-partial-aggregation plan. This was confirmed across multiple CI runs (seeds 5500 and 9886) where the fuzzer crashes on plan facebookincubator#14 (FINAL STREAMING over LocalMerge with forced abandon-partial-aggregation). The crash is a NULL pointer dereference in the aggregation framework, not in the first() function implementation itself. Adding first to the skip list until the root cause in the streaming aggregation framework is fixed. Differential Revision: D95251892
1 parent 2042c2a commit 7e016f4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

velox/functions/sparksql/fuzzer/SparkAggregationFuzzerTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ int main(int argc, char** argv) {
7878
// following names.
7979
std::unordered_set<std::string> skipFunctions = {
8080
"bloom_filter_agg",
81+
// Crashes with SIGSEGV during streaming aggregation + LocalMerge +
82+
// abandon-partial-aggregation with complex ROW group-by keys.
83+
// https://github.com/facebookincubator/velox/issues/16632
84+
"first",
8185
"first_ignore_null",
8286
"last_ignore_null",
8387
"regr_replacement",

0 commit comments

Comments
 (0)