Skip to content

Commit 855fff3

Browse files
xiaodouchenmeta-codesync[bot]
authored andcommitted
refactor: Remove unused functions in TextReader (facebookincubator#15317)
Summary: Remove unused functions `getByte()` and `getByteUnchecked()` in TextReader. Pull Request resolved: facebookincubator#15317 Reviewed By: kgpai Differential Revision: D85881716 Pulled By: kevinwilfong fbshipit-source-id: c1955e21b62dbbf0ab14383f52077b8e8ff8146a
1 parent 40a4a81 commit 855fff3

File tree

1 file changed

+0
-54
lines changed

1 file changed

+0
-54
lines changed

velox/dwio/text/reader/TextReader.cpp

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -559,18 +559,6 @@ void TextRowReader::setValueFromString(
559559
}
560560
}
561561

562-
uint8_t TextRowReader::getByte(DelimType& delim) {
563-
setNone(delim);
564-
auto v = getByteUnchecked(delim);
565-
if (isNone(delim)) {
566-
if (v == '\r') {
567-
v = getByteUnchecked<true>(delim); // always returns '\n' in this case
568-
}
569-
delim = getDelimType(v);
570-
}
571-
return v;
572-
}
573-
574562
uint8_t TextRowReader::getByteOptimized(DelimType& delim) {
575563
setNone(delim);
576564
auto v = getByteUncheckedOptimized(delim);
@@ -612,48 +600,6 @@ DelimType TextRowReader::getDelimType(uint8_t v) {
612600
return delim;
613601
}
614602

615-
template <bool skipLF>
616-
char TextRowReader::getByteUnchecked(DelimType& delim) {
617-
if (atEOL_) {
618-
if (!skipLF) {
619-
delim = DelimTypeEOR; // top level EOR
620-
}
621-
return '\n';
622-
}
623-
624-
try {
625-
char v;
626-
if (!unreadData_.empty()) {
627-
v = unreadData_[0];
628-
unreadData_.erase(0, 1);
629-
} else {
630-
contents_->inputStream->readFully(&v, 1);
631-
}
632-
pos_++;
633-
634-
// only when previous char == '\r'
635-
if (skipLF) {
636-
if (v != '\n') {
637-
pos_--;
638-
return '\n';
639-
}
640-
} else {
641-
atSOL_ = false;
642-
}
643-
return v;
644-
} catch (EOFError&) {
645-
} catch (std::runtime_error& e) {
646-
if (std::string(e.what()).find("Short read of") != 0 && !skipLF) {
647-
throw;
648-
}
649-
}
650-
if (!skipLF) {
651-
setEOF();
652-
delim = DelimTypeEOR;
653-
}
654-
return '\n';
655-
}
656-
657603
template <bool skipLF>
658604
char TextRowReader::getByteUncheckedOptimized(DelimType& delim) {
659605
if (atEOL_) {

0 commit comments

Comments
 (0)