Skip to content

Commit 85eed2e

Browse files
committed
Revert Relaxed singleton in RemoteFunctionTest causing SEGFAULT
The SingletonVault::Type::Relaxed change was causing a SEGFAULT in the adapters CI build (Release + shared + mono_library). The test passes on main without this change. The singleton registration warning is non-fatal and does not need to be suppressed.
1 parent 800bee0 commit 85eed2e

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

velox/functions/remote/client/tests/RemoteFunctionTest.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
#include <folly/Singleton.h>
1817
#include <folly/SocketAddress.h>
1918
#include <folly/init/Init.h>
2019
#include <gmock/gmock.h>
@@ -406,12 +405,6 @@ VELOX_INSTANTIATE_TEST_SUITE_P(
406405

407406
int main(int argc, char** argv) {
408407
testing::InitGoogleTest(&argc, argv);
409-
// Use Relaxed mode to allow singleton registration after
410-
// registrationComplete() which is needed when building with shared
411-
// libraries (-DVELOX_BUILD_SHARED=ON) since fbthrift singletons are
412-
// registered when the shared library is loaded.
413-
folly::SingletonVault::singleton()->setType(
414-
folly::SingletonVault::Type::Relaxed);
415408
folly::Init init{&argc, &argv, false};
416409
return RUN_ALL_TESTS();
417410
}

0 commit comments

Comments
 (0)