fix: Change array_sort lambda signature

Krishna Pai · facebook-github-bot · commit 9b015b2874c2 · 2025-09-26T09:28:49.000-07:00
Summary: array_sort lambda signature is defined as function(T, T, bigint) , however Presto has this defined as function(T, T, int) . This causes the side car to fail array_sort queries that use this lambda. See details in [this issue](prestodb/presto#26146). This change changes the signature to match Presto which fixes the side car. Differential Revision: D83353566
diff --git a/velox/functions/lib/ArraySort.cpp b/velox/functions/lib/ArraySort.cpp
@@ -450,7 +450,7 @@ std::vector<std::shared_ptr<exec::FunctionSignature>> signatures(
             .typeVariable("T")
             .returnType("array(T)")
             .argumentType("array(T)")
-            .constantArgumentType("function(T,T,bigint)")
+            .constantArgumentType("function(T,T,integer)")
             .build());
   }
   return signatures;
diff --git a/velox/functions/prestosql/tests/ArraySortTest.cpp b/velox/functions/prestosql/tests/ArraySortTest.cpp
@@ -334,6 +334,7 @@ ArrayVectorPtr ArraySortTest::arrayVector<TestRowType>(
 }
 
 void ArraySortTest::SetUp() {
+  options_.parseIntegerAsBigint = false;
   for (const TypeKind type : kSupportedTypes) {
     switch (type) {
       case TypeKind::BOOLEAN:

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,7 @@ std::vector<std::shared_ptr<exec::FunctionSignature>> signatures(`
`450`	`450`	`.typeVariable("T")`
`451`	`451`	`.returnType("array(T)")`
`452`	`452`	`.argumentType("array(T)")`
`453`		`- .constantArgumentType("function(T,T,bigint)")`
	`453`	`+ .constantArgumentType("function(T,T,integer)")`
`454`	`454`	`.build());`
`455`	`455`	`}`
`456`	`456`	`return signatures;`
Original file line number	Diff line number	Diff line change
`@@ -334,6 +334,7 @@ ArrayVectorPtr ArraySortTest::arrayVector<TestRowType>(`
`334`	`334`	`}`
`335`	`335`
`336`	`336`	`void ArraySortTest::SetUp() {`
	`337`	`+ options_.parseIntegerAsBigint = false;`
`337`	`338`	`for (const TypeKind type : kSupportedTypes) {`
`338`	`339`	`switch (type) {`
`339`	`340`	`case TypeKind::BOOLEAN:`