Skip to content

Commit bbf1f34

Browse files
peterenescufacebook-github-bot
authored andcommitted
feat: Create internal TableEvolutionFuzzer and add internal Nimble support during runs (facebookincubator#13441)
Summary: Pull Request resolved: facebookincubator#13441 Creates TableEvolutionFuzzer in internal Velox to test on internal Nimble. Here are some of the changes necessary ro accomplish this: * We leverage the TableEvolutionFuzzer class defined in external Velox repo and build a local instance to run in our new fuzzer. * (Not a significant change) I've added a function to the subclass to verify the supported file formats. Not necessary but wanted to note that we can and should override functions where necessary. Because the fuzzer is pretty limited right now, this is just a footnote for future updates and enhancments * (Another small item) I've added a fuzzer test flag to allow users to specify file formats during runs. Another small task but we should update and enhance the flags where necessary. Reviewed By: Yuhta Differential Revision: D74100062 fbshipit-source-id: b30b77ab689e4b63c27f248923fc7a062576224f
1 parent 984d561 commit bbf1f34

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

velox/dwio/common/FileSink.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,14 @@ class LocalFileSink : public FileSink {
169169

170170
static void registerFactory();
171171

172+
// TODO: Hack to make Alpha writer work with Velox. To be removed after Alpha
173+
// writer takes DataSink directly.
174+
// TODO revisit after T225172934
175+
std::unique_ptr<WriteFile> toWriteFile() {
176+
markClosed();
177+
return std::move(writeFile_);
178+
}
179+
172180
protected:
173181
// 'initializeWriter' is false if it is used by FaultyFileSink which setups
174182
// the write file through the fault filesystem.

0 commit comments

Comments
 (0)