Fix some radio view css to improve accessibility in disabled mode (#4882)

sarthak-marwaha · web-flow · commit 1e823a513d09 · 2026-03-04T12:31:08.000-05:00
diff --git a/src/foam/u2/view/RadioButton.js b/src/foam/u2/view/RadioButton.js
@@ -30,9 +30,9 @@ foam.CLASS({
     {
       name: 'selectedColor',
       expression: function(isSelected, isDisabled) {
-        if ( isDisabled ) return '$backgroundSecondary';
+        if ( isDisabled ) return '$backgroundInverseTertiary';
         if ( isSelected ) return '$backgroundBrand';
-        return '$backgroundInverseSecondary';
+        return '$backgroundInverse';
       }
     },
     {
diff --git a/src/foam/u2/view/RadioView.js b/src/foam/u2/view/RadioView.js
@@ -37,6 +37,9 @@ foam.CLASS({
       cursor: pointer;
       align-items: center;
     }
+    ^ input[type='radio']:disabled+ label {
+      cursor: not-allowed;
+    }
     ^ .choice {
       white-space: nowrap;
     }

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,9 @@ foam.CLASS({`
`30`	`30`	`{`
`31`	`31`	`name: 'selectedColor',`
`32`	`32`	`expression: function(isSelected, isDisabled) {`
`33`		`- if ( isDisabled ) return '$backgroundSecondary';`
	`33`	`+ if ( isDisabled ) return '$backgroundInverseTertiary';`
`34`	`34`	`if ( isSelected ) return '$backgroundBrand';`
`35`		`- return '$backgroundInverseSecondary';`
	`35`	`+ return '$backgroundInverse';`
`36`	`36`	`}`
`37`	`37`	`},`
`38`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ foam.CLASS({`
`37`	`37`	`cursor: pointer;`
`38`	`38`	`align-items: center;`
`39`	`39`	`}`
	`40`	`+ ^ input[type='radio']:disabled+ label {`
	`41`	`+ cursor: not-allowed;`
	`42`	`+ }`
`40`	`43`	`^ .choice {`
`41`	`44`	`white-space: nowrap;`
`42`	`45`	`}`