Skip to content

Commit 56231e0

Browse files
committed
Merge branch 'development' of github.com:kgrgreer/foam3 into development
2 parents 7310c18 + 812ddc4 commit 56231e0

File tree

5 files changed

+32
-9
lines changed

5 files changed

+32
-9
lines changed

src/foam/core/auth/PermissionTableView.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ foam.CLASS({
1515
name: 'PermissionTableView',
1616
extends: 'foam.u2.Controller',
1717

18+
mixins: ['foam.u2.Router'],
19+
1820
implements: [ 'foam.mlang.Expressions' ],
1921

2022
requires: [
@@ -234,10 +236,18 @@ foam.CLASS({
234236
expression: function(filteredGs) {
235237
return filteredGs.length;
236238
}
239+
},
240+
{
241+
name: 'viewTitle',
242+
value: 'Permission Matrix'
237243
}
238244
],
239245

240246
methods: [
247+
function init() {
248+
this.addCrumb();
249+
this.onDetach(this.stack?.setTitle(this.viewTitle$, this));
250+
},
241251
async function initMap() {
242252
var self = this;
243253
var perms = await this.groupPermissionJunctionDAO.select();
@@ -272,10 +282,6 @@ foam.CLASS({
272282

273283
callIf(this.showSearch, function() { this.start()
274284
.addClass(this.myClass('header'))
275-
.start('span')
276-
.style({padding: '8px'})
277-
.add('Permission Matrix')
278-
.end()
279285
.add(this.G_QUERY, ' ', this.QUERY)
280286
.end(); })
281287

src/foam/u2/PropertyBorder.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,11 @@ foam.CLASS({
285285
justify-content: space-between;
286286
gap: 0.8rem;
287287
}
288+
^labels {
289+
display: flex;
290+
flex-direction: column;
291+
gap: 0.2lh;
292+
}
288293
`,
289294

290295
methods: [
@@ -297,6 +302,7 @@ foam.CLASS({
297302
start().
298303
addClass(this.myClass('labelHolder')).
299304
start().
305+
addClass(this.myClass('labels')).
300306
add(labelSlot).
301307
add(supportingLabelSlot).
302308
end().
@@ -355,7 +361,7 @@ foam.CLASS({
355361
this
356362
.start(self.ExpandableBorder, { expanded$: self.helpEnabled$, title: self.HELP })
357363
.style({ 'flex-basis': '100%', width: '100%' })
358-
.start('p').add(prop.help).end()
364+
.start().addClass('p').add(prop.help).end()
359365
.end();
360366
});
361367
}

src/foam/u2/borders/ExpandableBorder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
background:$backgroundDefault;
2727
border-radius: 4px;
2828
border: 1px solid $borderDefault;
29-
padding: 24px;
29+
padding: 12px;
3030
}
3131
^ h6{
3232
padding-bottom: 12px;

src/foam/u2/dialog/InlineNotificationMessage.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
},
3939
{
4040
name: 'INFO',
41-
color: '$textBrand',
41+
color: '$backgroundBrand',
4242
glyph: 'checkmark'
4343
},
4444
{
@@ -95,10 +95,16 @@ foam.CLASS({
9595
expression: function(type) {
9696
return (this.type && foam.CSS.returnTokenValue(this.type.color, this.cls_, this.__subContext__)) || '#FFFFFF';
9797
},
98+
adapt: function(o,n) {
99+
return foam.CSS.returnTokenValue(n, this.cls_, this.__subContext__);
100+
},
98101
documentation: 'Border color for the view and icon background. Defaults to type color'
99102
},
100103
{
101104
name: 'iconColor',
105+
adapt: function(o,n) {
106+
return foam.CSS.returnTokenValue(n, this.cls_, this.__subContext__);
107+
},
102108
factory: function() {
103109
return (this.type && foam.CSS.returnTokenValue(this.type.background, this.cls_, this.__subContext__)) || '#FFFFFF';
104110
},

src/foam/u2/dialog/StyledModal.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,8 @@ foam.CLASS({
136136
{
137137
class: 'String',
138138
name: 'description'
139-
}
139+
},
140+
'wrapper_'
140141
],
141142

142143
methods: [
@@ -155,7 +156,7 @@ foam.CLASS({
155156
.addClass(this.myClass('background'))
156157
.on('click', this.closeable ? this.close : null)
157158
.end()
158-
.start(this.Rows)
159+
.start(this.Rows, {}, this.wrapper_$)
159160
.addClass(this.myClass('wrapper'))
160161
.style({
161162
'max-height': this.slot(function(fullscreen, maxHeight) { return ! fullscreen ? maxHeight : ''}),
@@ -189,6 +190,10 @@ foam.CLASS({
189190
.end()
190191
.end();
191192
},
193+
function styleWrapper() {
194+
this.wrapper_.style(...arguments);
195+
return this;
196+
},
192197
function addBody() {
193198
return this.E().tag('', null, this.content$);
194199
},

0 commit comments

Comments
 (0)