Fix toMQL() scientific notation, falsy value bugs, and missing implementations (#4908)

* fix(mlang): prevent scientific notation and falsy value bugs in toMQL output

* fix(mlang): wrap multi-arg Or.toMQL output in parentheses

Author: abdelaziz-mahdy

src/foam/mlang/Constant.js

@@ -74,6 +74,17 @@ foam.CLASS({
 
       if ( foam.String.isInstance(this.value) )
         return '\"' + this.value + '\"';
+
+      if ( typeof this.value === 'number' && ! Number.isInteger(this.value) && isFinite(this.value) ) {
+        var s = this.value.toFixed(20);
+        s = s.replace(/0+$/, '');
+        if ( s.endsWith('.') ) s += '0';
+        return s;
+      }
+
+      if ( typeof this.value === 'boolean' )
+        return this.value ? 'true' : 'false';
+
       return this.value;
     }
   ]

src/foam/mlang/expr/Dot.js

@@ -33,6 +33,14 @@ foam.CLASS({
     {
       class: 'foam.mlang.ExprProperty',
       name: 'arg2'
+    },
+    {
+      name: 'name',
+      transient: true,
+      flags: ['js'],
+      getter: function() {
+        return this.arg2.name;
+      }
     }
   ],
 

src/foam/mlang/predicate/ContainsIC.js

@@ -44,8 +44,7 @@ return ( s1 instanceof String && ((String) s1).toUpperCase().contains(s2) );`
 
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
+      if ( arg2 == null ) return null;
       return this.arg1.name + ':' + arg2;
     }
 

src/foam/mlang/predicate/Eq.js

@@ -51,8 +51,7 @@ return FOAM_utils.equals(v1, v2)
 
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
+      if ( arg2 == null ) return null;
       return this.arg1.name + '=' + arg2;
     }
   ]

src/foam/mlang/predicate/Gt.js

@@ -26,8 +26,7 @@ foam.CLASS({
     },
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
+      if ( arg2 == null ) return null;
       return this.arg1.name + '>' + arg2;
     }
   ]

src/foam/mlang/predicate/Gte.js

@@ -26,8 +26,7 @@ foam.CLASS({
     },
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
+      if ( arg2 == null ) return null;
       return this.arg1.name + '>=' + arg2;
     }
   ]

src/foam/mlang/predicate/Has.js

@@ -55,6 +55,9 @@ foam.CLASS({
       name: 'createStatement',
       // TODO: check for empty array
       javaCode: `return " (" + getArg1().createStatement() + " <> '') is not true ";`
+    },
+    function toMQL() {
+      return this.arg1.name + ' IS NOT EMPTY';
     }
   ]
 });

src/foam/mlang/predicate/In.js

@@ -164,9 +164,9 @@ return false
     },
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
-      return this.arg1.name + ':' + arg2.join(',');
+      if ( arg2 == null ) return null;
+      if ( Array.isArray(arg2) ) return this.arg1.name + ':' + arg2.join(',');
+      return this.arg1.name + ':' + arg2;
     }
   ]
 });

src/foam/mlang/predicate/Lt.js

@@ -26,8 +26,7 @@ foam.CLASS({
     },
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
+      if ( arg2 == null ) return null;
       return this.arg1.name + '<' + arg2;
     }
   ]

src/foam/mlang/predicate/Lte.js

@@ -26,8 +26,7 @@ foam.CLASS({
     },
     function toMQL() {
       var arg2 = this.arg2ToMQL();
-      if ( ! arg2 )
-        return null;
+      if ( arg2 == null ) return null;
       return this.arg1.name + '<=' + arg2;
     }
   ]