refactoring custom user provider and admin user controller

Author: kikoval

src/Legislator/LegislatorBundle/Controller/AdminUserController.php

@@ -42,8 +42,8 @@ public function processGroupFromAction($id)
     	}
 
     	$em = $this->getDoctrine()->getEntityManager();
-    	$em->persist($group);
-    	$em->flush($user);
+    	$em->persist($user);
+    	$em->flush();
 
     	return $this->redirect($this->generateUrl('legislator_user_list'));
     }

src/Legislator/LegislatorBundle/Resources/config/services.yml

@@ -4,7 +4,7 @@ parameters:
 services:
     legislator_user.provider:
         class: Legislator\LegislatorBundle\Security\LegislatorUserProvider
-        arguments: ["@fos_user.user_manager", "@service_container", "%cosign_login_enabled%"]
+        arguments: ["@fos_user.user_manager", "@service_container"]
 
     legislator_user.registration.form.type:
         class: Legislator\LegislatorBundle\Form\RegistrationFormType

src/Legislator/LegislatorBundle/Security/LegislatorUserProvider.php

@@ -6,8 +6,8 @@
 use Symfony\Component\Security\Core\User\UserInterface as SecurityUserInterface;
 use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
 use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
-use Symfony\Component\DependencyInjection\Container;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
+use Symfony\Component\DependencyInjection\ContainerInterface;
 
 use FOS\UserBundle\Model\User;
 use FOS\UserBundle\Model\UserInterface;
@@ -16,11 +16,12 @@
 
 class LegislatorUserProvider implements UserProviderInterface {
 
-	public function __construct(UserManagerInterface $userManager, Container $container, $cosign_login_enabled=FALSE)
+	public function __construct(UserManagerInterface $userManager, ContainerInterface $container)
 	{
 	  $this->userManager = $userManager;
 	  $this->container = $container;
-	  $this->cosign_login_enabled = $cosign_login_enabled;
+
+	  $this->cosign_login_enabled = $this->container->getParameter('cosign_login_enabled');
 	}
 
 	public function loadUserByUsername($username)
@@ -58,7 +59,6 @@ public function loadUserByUsername($username)
 
 			$this->userManager->updateUser($user);
 
-
 		} else {
             if (!$user) {
                 throw new UsernameNotFoundException(sprintf('Username "%s" does not exist.', $username));