Skip to content

Commit 516ec6c

Browse files
kilmajsterŁukasz Włódarczyk
andauthored
bumped java to v17 and updated dependencies (#115)
* bumped java to v17 an dupdated dependencies * bumped java to v17 --------- Co-authored-by: Łukasz Włódarczyk <[email protected]>
1 parent 667f932 commit 516ec6c

File tree

9 files changed

+58
-73
lines changed

9 files changed

+58
-73
lines changed

.github/test-app-sb-2x/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<name>test-app</name>
1515
<description>Dummy app for tests with spring-boot v2</description>
1616
<properties>
17-
<java.version>11</java.version>
17+
<java.version>17</java.version>
1818
<ngrok-spring-boot-starter.version>SNAPSHOT</ngrok-spring-boot-starter.version>
1919
</properties>
2020
<dependencies>

.github/test-app-sb-3x/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.springframework.boot</groupId>
77
<artifactId>spring-boot-starter-parent</artifactId>
8-
<version>3.1.3</version>
8+
<version>3.3.5</version>
99
<relativePath/> <!-- lookup parent from repository -->
1010
</parent>
1111
<groupId>io.github.kilmajster</groupId>

.github/workflows/automation-test-macos.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ jobs:
1515
steps:
1616
- uses: actions/checkout@v2
1717

18-
- name: Set up JDK 11
18+
- name: Set up JDK 17
1919
uses: actions/setup-java@v3
2020
with:
2121
distribution: 'adopt'
22-
java-version: '11'
22+
java-version: '17'
2323

2424
- name: Silent install main project
2525
run: mvn --batch-mode --no-transfer-progress install -Dmaven.test.skip=true
@@ -30,12 +30,6 @@ jobs:
3030
NGROK_AUTH_TOKEN: ${{ secrets.NGROK_AUTH_TOKEN }}
3131
run: mvn --batch-mode --no-transfer-progress test
3232

33-
- name: Set up JDK 17
34-
uses: actions/setup-java@v3
35-
with:
36-
distribution: 'adopt'
37-
java-version: '17'
38-
3933
- name: Run automation tests with latest ngrok-spring-boot-starter version on test-app and spring-boot v3
4034
working-directory: ./.github/test-app-sb-3x/
4135
env:

.github/workflows/automation-test-ubuntu.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ jobs:
1515
steps:
1616
- uses: actions/checkout@v2
1717

18-
- name: Set up JDK 11
18+
- name: Set up JDK 17
1919
uses: actions/setup-java@v3
2020
with:
2121
distribution: 'adopt'
22-
java-version: '11'
22+
java-version: '17'
2323

2424
- name: Silent install main project
2525
run: mvn --batch-mode --no-transfer-progress install -Dmaven.test.skip=true
@@ -30,12 +30,6 @@ jobs:
3030
NGROK_AUTH_TOKEN: ${{ secrets.NGROK_AUTH_TOKEN }}
3131
run: mvn --batch-mode --no-transfer-progress test
3232

33-
- name: Set up JDK 17
34-
uses: actions/setup-java@v3
35-
with:
36-
distribution: 'adopt'
37-
java-version: '17'
38-
3933
- name: Run automation tests with latest ngrok-spring-boot-starter version on test-app and spring-boot v3
4034
working-directory: ./.github/test-app-sb-3x/
4135
env:

.github/workflows/automation-test-windows.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ jobs:
1515
steps:
1616
- uses: actions/checkout@v2
1717

18-
- name: Set up JDK 11
18+
- name: Set up JDK 17
1919
uses: actions/setup-java@v3
2020
with:
2121
distribution: 'adopt'
22-
java-version: '11'
22+
java-version: '17'
2323

2424
- name: Silent install main project
2525
run: mvn --batch-mode --no-transfer-progress install -DskipTests
@@ -30,12 +30,6 @@ jobs:
3030
NGROK_AUTH_TOKEN: ${{ secrets.NGROK_AUTH_TOKEN }}
3131
run: mvn --batch-mode --no-transfer-progress test
3232

33-
- name: Set up JDK 17
34-
uses: actions/setup-java@v3
35-
with:
36-
distribution: 'adopt'
37-
java-version: '17'
38-
3933
- name: Run automation tests with latest ngrok-spring-boot-starter version on test-app and spring-boot v3
4034
working-directory: ./.github/test-app-sb-3x/
4135
env:

.github/workflows/maven.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ jobs:
1111
steps:
1212
- uses: actions/checkout@v2
1313

14-
- name: Set up JDK 1.8
14+
- name: Set up JDK 17
1515
uses: actions/setup-java@v1
1616
with:
17-
java-version: 1.8
17+
java-version: 17
1818

1919
- name: Build with Maven
2020
run: mvn -B package --file pom.xml

.github/workflows/release-github-tag.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- name: Set up Maven Central Repository
1414
uses: actions/setup-java@v1
1515
with:
16-
java-version: 1.8
16+
java-version: 17
1717
server-id: ossrh
1818
server-username: MAVEN_USERNAME
1919
server-password: MAVEN_PASSWORD

README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
<img align="center" src="https://img.shields.io/github/license/kilmajster/ngrok-spring-boot-starter?color=blue" alt="MIT license badge">
1313
</a>
1414
<br>
15-
<a href="https://github.com/kilmajster/ngrok-spring-boot-starter/actions?query=workflow%3A%22CI+on+windows-latest%22">
16-
<img align="center" src="https://github.com/kilmajster/ngrok-spring-boot-starter/workflows/CI%20on%20windows-latest/badge.svg" alt="CI on Windows">
15+
<a href="https://github.com/kilmajster/ngrok-spring-boot-starter/actions/workflows/automation-test-windows.yml">
16+
<img align="center" src="https://github.com/kilmajster/ngrok-spring-boot-starter/actions/workflows/automation-test-windows.yml/badge.svg" alt="CI on Windows">
1717
</a>
18-
<a href="https://github.com/kilmajster/ngrok-spring-boot-starter/actions?query=workflow%3A%22CI+on+ubuntu-latest%22">
19-
<img align="center" src="https://github.com/kilmajster/ngrok-spring-boot-starter/workflows/CI%20on%20ubuntu-latest/badge.svg" alt="CI on Ubuntu">
18+
<a href="https://github.com/kilmajster/ngrok-spring-boot-starter/actions/workflows/automation-test-ubuntu.yml">
19+
<img align="center" src="https://github.com/kilmajster/ngrok-spring-boot-starter/actions/workflows/automation-test-ubuntu.yml/badge.svg" alt="CI on Ubuntu">
2020
</a>
21-
<a href="https://github.com/kilmajster/ngrok-spring-boot-starter/actions?query=workflow%3A%22CI+on+macos-latest%22">
22-
<img align="center" src="https://github.com/kilmajster/ngrok-spring-boot-starter/workflows/CI%20on%20macos-latest/badge.svg" alt="CI on MacOS">
21+
<a href="https://github.com/kilmajster/ngrok-spring-boot-starter/actions/workflows/automation-test-macos.yml">
22+
<img align="center" src="https://github.com/kilmajster/ngrok-spring-boot-starter/actions/workflows/automation-test-macos.yml/badge.svg" alt="CI on MacOS">
2323
</a>
2424
</h1>
2525
<p align="center">
@@ -45,7 +45,9 @@ with the remote links, just like it's done below 👇
4545
<img src="https://github.com/kilmajster/ngrok-spring-boot-starter/blob/main/.github/demo.gif" alt="demo gif">
4646
</p>
4747

48-
Code of demo application available [here](https://github.com/kilmajster/demo).
48+
Code of demo application is available
49+
[here](https://github.com/kilmajster/ngrok-spring-boot-starter/tree/main/.github/test-app-sb-2x) for spring-boot v2 and
50+
[here](https://github.com/kilmajster/ngrok-spring-boot-starter/tree/main/.github/test-app-sb-3x) for v3.
4951

5052
## Dependency
5153
- maven:

pom.xml

Lines changed: 38 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -59,26 +59,27 @@
5959
<parent>
6060
<groupId>org.springframework.boot</groupId>
6161
<artifactId>spring-boot-starter-parent</artifactId>
62-
<version>2.7.18</version>
62+
<version>3.3.5</version>
6363
<relativePath/>
6464
</parent>
6565

6666
<properties>
6767
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
6868
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
6969

70-
<java.version>1.8</java.version>
70+
<java.version>17</java.version>
7171

72-
<maven-gpg-plugin.version>3.2.7</maven-gpg-plugin.version>
73-
<maven-javadoc-plugin.version>3.8.0</maven-javadoc-plugin.version>
74-
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
75-
76-
<commons-io.version>2.16.1</commons-io.version>
77-
<commons-lang3.version>3.15.0</commons-lang3.version>
72+
<commons-io.version>2.18.0</commons-io.version>
73+
<commons-lang3.version>3.17.0</commons-lang3.version>
7874
<commons-compress.version>1.27.1</commons-compress.version>
79-
<jackson-dataformat-yaml.version>2.17.2</jackson-dataformat-yaml.version>
75+
<jackson-dataformat-yaml.version>2.18.1</jackson-dataformat-yaml.version>
76+
77+
<spring-cloud-contract-wiremock.version>4.1.4</spring-cloud-contract-wiremock.version>
8078

81-
<spring-cloud-contract-wiremock.version>3.1.10</spring-cloud-contract-wiremock.version>
79+
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
80+
<maven-gpg-plugin.version>3.2.7</maven-gpg-plugin.version>
81+
<maven-javadoc-plugin.version>3.11.1</maven-javadoc-plugin.version>
82+
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
8283
</properties>
8384

8485
<dependencies>
@@ -155,40 +156,40 @@
155156
<target>${java.version}</target>
156157
</configuration>
157158
</plugin>
158-
<plugin>
159-
<groupId>org.apache.maven.plugins</groupId>
160-
<artifactId>maven-javadoc-plugin</artifactId>
161-
<version>${maven-javadoc-plugin.version}</version>
162-
<executions>
163-
<execution>
164-
<id>attach-javadocs</id>
165-
<goals>
166-
<goal>jar</goal>
167-
</goals>
168-
</execution>
169-
</executions>
170-
</plugin>
171-
<plugin>
172-
<groupId>org.apache.maven.plugins</groupId>
173-
<artifactId>maven-source-plugin</artifactId>
174-
<version>${maven-source-plugin.version}</version>
175-
<executions>
176-
<execution>
177-
<id>attach-sources</id>
178-
<goals>
179-
<goal>jar-no-fork</goal>
180-
</goals>
181-
</execution>
182-
</executions>
183-
</plugin>
184159
</plugins>
185-
186160
</build>
161+
187162
<profiles>
188163
<profile>
189164
<id>ossrh</id>
190165
<build>
191166
<plugins>
167+
<plugin>
168+
<groupId>org.apache.maven.plugins</groupId>
169+
<artifactId>maven-javadoc-plugin</artifactId>
170+
<version>${maven-javadoc-plugin.version}</version>
171+
<executions>
172+
<execution>
173+
<id>attach-javadocs</id>
174+
<goals>
175+
<goal>jar</goal>
176+
</goals>
177+
</execution>
178+
</executions>
179+
</plugin>
180+
<plugin>
181+
<groupId>org.apache.maven.plugins</groupId>
182+
<artifactId>maven-source-plugin</artifactId>
183+
<version>${maven-source-plugin.version}</version>
184+
<executions>
185+
<execution>
186+
<id>attach-sources</id>
187+
<goals>
188+
<goal>jar-no-fork</goal>
189+
</goals>
190+
</execution>
191+
</executions>
192+
</plugin>
192193
<plugin>
193194
<groupId>org.apache.maven.plugins</groupId>
194195
<artifactId>maven-gpg-plugin</artifactId>

0 commit comments

Comments
 (0)