Skip to content

Commit eb4dfde

Browse files
danielhbalinefm
authored andcommitted
Use Websocket facilities from WoK
The 'websocket' module was moved from Kimchi to WoK to allow WoK and all its plug-ins to have websocket capabilities. This patch removes the existing websocket module inside Kimchi and updates all the references to use the WoK module instead. The initialization of the ws_proxy was also removed from root.py - this process is also being done by WoK now. Signed-off-by: Daniel Henrique Barboza <[email protected]>
1 parent 09d9a39 commit eb4dfde

10 files changed

+6
-133
lines changed

contrib/DEBIAN/control.in

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ Depends: wok (>= 2.1.0),
77
ginger-base,
88
python-imaging,
99
python-configobj,
10-
websockify,
1110
novnc,
1211
python-jsonschema (>= 1.3.0),
1312
python-libvirt,

contrib/kimchi.spec.fedora.in

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ Requires: gettext
1414
Requires: libvirt
1515
Requires: libvirt-python
1616
Requires: libvirt-daemon-config-network
17-
Requires: python-websockify
1817
Requires: python-configobj
1918
Requires: novnc
2019
Requires: python-pillow

contrib/kimchi.spec.suse.in

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ Requires: gettext-tools
1414
Requires: libvirt
1515
Requires: libvirt-python
1616
Requires: libvirt-daemon-config-network
17-
Requires: python-websockify
1817
Requires: python-configobj
1918
Requires: novnc
2019
Requires: python-Pillow

docs/fedora-deps.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Runtime Dependencies
2828
$ sudo yum install libvirt-python libvirt libvirt-daemon-config-network \
2929
qemu-kvm python-ethtool sos python-ipaddr nfs-utils \
3030
iscsi-initiator-utils pyparted python-libguestfs \
31-
libguestfs-tools python-websockify novnc spice-html5 \
31+
libguestfs-tools novnc spice-html5 \
3232
python-configobj python-magic python-paramiko \
3333
python-pillow
3434

docs/opensuse-deps.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ Runtime Dependencies
3333
python-ipaddr libvirt-daemon-config-network \
3434
nfs-client open-iscsi python-parted \
3535
python-libguestfs python-configobj guestfs-tools \
36-
python-websockify novnc python-magic \
37-
python-paramiko python-Pillow
36+
novnc python-magic python-paramiko python-Pillow
3837

3938
Packages required for UI development
4039
------------------------------------

docs/ubuntu-deps.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Build Dependencies
1515
Runtime Dependencies
1616
--------------------
1717

18-
$ sudo apt-get install python-configobj websockify novnc python-libvirt \
18+
$ sudo apt-get install python-configobj novnc python-libvirt \
1919
libvirt-bin nfs-common qemu-kvm python-parted \
2020
python-ethtool sosreport python-ipaddr \
2121
python-lxml open-iscsi python-guestfs \

model/vms.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
from lxml.builder import E
3737
from xml.etree import ElementTree
3838

39+
from wok import websocket
3940
from wok.asynctask import AsyncTask
4041
from wok.config import config
4142
from wok.exception import InvalidOperation, InvalidParameter
@@ -48,7 +49,6 @@
4849
from wok.xmlutils.utils import xml_item_remove, xml_item_update
4950

5051
from wok.plugins.kimchi import model
51-
from wok.plugins.kimchi import websocket
5252
from wok.plugins.kimchi import serialconsole
5353
from wok.plugins.kimchi.config import READONLY_POOL_TYPE, get_kimchi_version
5454
from wok.plugins.kimchi.kvmusertests import UserTests

root.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import os
2323
import tempfile
2424

25-
from wok.plugins.kimchi import config, mockmodel, websocket
25+
from wok.plugins.kimchi import config, mockmodel
2626
from wok.plugins.kimchi.i18n import messages
2727
from wok.plugins.kimchi.control import sub_nodes
2828
from wok.plugins.kimchi.model import model as kimchiModel
@@ -59,8 +59,6 @@ def remove_objectstore():
5959
cherrypy.engine.subscribe('exit', remove_objectstore)
6060
else:
6161
self.model = kimchiModel.Model()
62-
ws_proxy = websocket.new_ws_proxy()
63-
cherrypy.engine.subscribe('exit', ws_proxy.terminate)
6462

6563
dev_env = wok_options.environment != 'production'
6664
super(Kimchi, self).__init__(self.model, dev_env)

tests/test_mockmodel.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def setUpModule():
4646
iso_gen.construct_fake_iso(fake_iso, True, '12.04', 'ubuntu')
4747

4848

49-
def tearDown():
49+
def tearDownModule():
5050
test_server.stop()
5151
os.unlink(fake_iso)
5252

websocket.py

-121
This file was deleted.

0 commit comments

Comments
 (0)