Skip to content

Commit 292a8b7

Browse files
committed
🎨 (eslint-config-kinetics): remove eslint-plugin-prettier
Using `eslint-plugin-prettier` is slower than running prettier itself, the recommended approach is to run prettier first then follow by eslint to fix all the problems. VScode integration will be resolved once this PR gets merged prettier/prettier-vscode#2500.
1 parent c3013e8 commit 292a8b7

12 files changed

+26
-73
lines changed

.pnp.cjs

Lines changed: 9 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Binary file not shown.
Binary file not shown.

.yarn/versions/3a274f7f.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
releases:
2+
eslint-config-kinetics: patch

.yarn/versions/4e4c6e8c.yml

Lines changed: 0 additions & 2 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"root": true,
3-
"extends": "eslint-config-kinetics/prettier"
3+
"extends": "./prettier"
44
}

packages/eslint-config-kinetics/package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"eslint-plugin-flowtype": "^8.0.3",
2222
"eslint-plugin-import": "^2.25.4",
2323
"eslint-plugin-jsx-a11y": "^6.5.1",
24-
"eslint-plugin-prettier": "^4.0.0",
2524
"eslint-plugin-react": "^7.29.4",
2625
"eslint-plugin-react-hooks": "^4.3.0",
2726
"eslint-plugin-simple-import-sort": "^7.0.0",
@@ -32,12 +31,9 @@
3231
"@types/babel__core": "^7",
3332
"@types/babel__preset-env": "^7",
3433
"@types/eslint": "^8.4.1",
35-
"@types/prettier": "^2.4.4"
34+
"@types/prettier": "^2.6.0"
3635
},
3736
"peerDependencies": {
3837
"eslint": ">=8"
39-
},
40-
"engines": {
41-
"node": ">=14.0.0"
4238
}
4339
}

packages/eslint-config-kinetics/prettier.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,8 @@ require("@rushstack/eslint-patch/modern-module-resolution");
1010
* @type {import('eslint').Linter.Config}
1111
*/
1212
module.exports = {
13-
extends: ["plugin:prettier/recommended"],
13+
extends: ["prettier"],
1414
rules: {
15-
"prettier/prettier": [
16-
"error",
17-
{
18-
quoteProps: "consistent",
19-
},
20-
],
15+
"quote-props": ["error", "consistent"],
2116
},
2217
};

packages/eslint-config-kinetics/react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require("@rushstack/eslint-patch/modern-module-resolution");
1010
* @type {import('eslint').Linter.Config}
1111
*/
1212
module.exports = {
13-
extends: ["react-app", "eslint-config-kinetics/shared"],
13+
extends: ["react-app", "./shared"],
1414
rules: {
1515
"react/jsx-boolean-value": ["error", "never"],
1616
"react/jsx-no-bind": "warn", // performance

packages/eslint-config-kinetics/shared.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,10 @@ module.exports = {
1414
ecmaVersion: 2020,
1515
},
1616
plugins: ["simple-import-sort", "import"],
17-
extends: [
18-
"eslint-config-kinetics/prettier",
19-
"eslint-config-kinetics/typescript",
20-
],
17+
extends: ["./prettier", "./typescript"],
2118
rules: {
2219
"simple-import-sort/imports": "error",
2320
"simple-import-sort/exports": "error",
24-
2521
"sort-imports": "off",
2622
"import/first": "error",
2723
"import/newline-after-import": "error",

packages/eslint-config-kinetics/typescript.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ module.exports = {
3737
message: "Use symbol instead",
3838
fixWith: "symbol",
3939
},
40-
4140
"Function": {
4241
message: [
4342
"The `Function` type accepts any function-like value.",

yarn.lock

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3139,13 +3139,20 @@ __metadata:
31393139
languageName: node
31403140
linkType: hard
31413141

3142-
"@types/prettier@npm:^2.1.5, @types/prettier@npm:^2.4.4":
3142+
"@types/prettier@npm:^2.1.5":
31433143
version: 2.4.4
31443144
resolution: "@types/prettier@npm:2.4.4"
31453145
checksum: 2c2cc57efd49c7d8907415a72f96c84a6dd8696dd3bf8aa4ca3a667427bebf71cbfbc912673624bdfc935d272d1c008c639cf155f6449315990a4dc110f0d216
31463146
languageName: node
31473147
linkType: hard
31483148

3149+
"@types/prettier@npm:^2.6.0":
3150+
version: 2.6.1
3151+
resolution: "@types/prettier@npm:2.6.1"
3152+
checksum: b25ec46d18129fa40c1a1f42feb7406e8f19901ba5261ba3c71600ad14996ae07b4f4b727a9b83da673948011e59d870fc519166f05b5d49e9ad39db1aea8c93
3153+
languageName: node
3154+
linkType: hard
3155+
31493156
"@types/prop-types@npm:*":
31503157
version: 15.7.4
31513158
resolution: "@types/prop-types@npm:15.7.4"
@@ -5851,7 +5858,7 @@ __metadata:
58515858
"@types/babel__core": ^7
58525859
"@types/babel__preset-env": ^7
58535860
"@types/eslint": ^8.4.1
5854-
"@types/prettier": ^2.4.4
5861+
"@types/prettier": ^2.6.0
58555862
"@typescript-eslint/eslint-plugin": ^5.15.0
58565863
"@typescript-eslint/parser": ^5.15.0
58575864
babel-eslint: ^10.1.0
@@ -5861,7 +5868,6 @@ __metadata:
58615868
eslint-plugin-flowtype: ^8.0.3
58625869
eslint-plugin-import: ^2.25.4
58635870
eslint-plugin-jsx-a11y: ^6.5.1
5864-
eslint-plugin-prettier: ^4.0.0
58655871
eslint-plugin-react: ^7.29.4
58665872
eslint-plugin-react-hooks: ^4.3.0
58675873
eslint-plugin-simple-import-sort: ^7.0.0
@@ -6067,21 +6073,6 @@ __metadata:
60676073
languageName: node
60686074
linkType: hard
60696075

6070-
"eslint-plugin-prettier@npm:^4.0.0":
6071-
version: 4.0.0
6072-
resolution: "eslint-plugin-prettier@npm:4.0.0"
6073-
dependencies:
6074-
prettier-linter-helpers: ^1.0.0
6075-
peerDependencies:
6076-
eslint: ">=7.28.0"
6077-
prettier: ">=2.0.0"
6078-
peerDependenciesMeta:
6079-
eslint-config-prettier:
6080-
optional: true
6081-
checksum: 03d69177a3c21fa2229c7e427ce604429f0b20ab7f411e2e824912f572a207c7f5a41fd1f0a95b9b8afe121e291c1b1f1dc1d44c7aad4b0837487f9c19f5210d
6082-
languageName: node
6083-
linkType: hard
6084-
60856076
"eslint-plugin-react-hooks@npm:^4.2.0, eslint-plugin-react-hooks@npm:^4.3.0":
60866077
version: 4.3.0
60876078
resolution: "eslint-plugin-react-hooks@npm:4.3.0"

0 commit comments

Comments
 (0)