Skip to content

Commit

Permalink
fix(rest): Separate titleField type between GET and UPDATE (#3159)
Browse files Browse the repository at this point in the history
  • Loading branch information
cy-takeuchi authored Feb 6, 2025
1 parent 2609f13 commit 9ed8f0d
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions packages/rest-api-client/src/client/types/app/setting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ type Theme =
| "YELLOW"
| "BLACK";

type TitleField =
| {
selectionMode: "AUTO";
}
| {
selectionMode: "MANUAL";
code: string;
};

export type GetAppSettingsForRequest = {
app: AppID;
lang?: AppLang;
Expand All @@ -41,7 +32,10 @@ export type GetAppSettingsForResponse = {
}
| { type: "PRESET"; key: string };
theme: Theme;
titleField: TitleField;
titleField: {
selectionMode: "AUTO" | "MANUAL";
code: string;
};
enableThumbnails: boolean;
enableBulkDeletion: boolean;
enableComments: boolean;
Expand All @@ -68,7 +62,9 @@ export type UpdateAppSettingsForRequest = {
}
| { type: "PRESET"; key: string };
theme?: Theme;
titleField?: TitleField;
titleField?:
| { selectionMode: "AUTO" }
| { selectionMode: "MANUAL"; code: string };
enableThumbnails?: boolean;
enableBulkDeletion?: boolean;
enableComments?: boolean;
Expand Down

0 comments on commit 9ed8f0d

Please sign in to comment.