clean up tests and remove all comments from code

Author: Kirill Platonov

lib/proxy_manager.rb

@@ -2,8 +2,6 @@
 require 'net/ping'
 
 module ProxyManager
-  # Define gem's root path
-  # @return [String] string path
   def self.root
     File.expand_path '../..', __FILE__
   end

lib/proxy_manager/proxy.rb

@@ -2,16 +2,6 @@ module ProxyManager
   class Proxy
     attr_reader :list
 
-    # Create main object
-    # @param proxies [Array, String] array of proxies or file with proxies
-    # @example
-    #   # from array
-    #   proxy = ProxyManager::Proxy.new(['127.0.0.1:80', '127.0.0.1:8080'])
-    #
-    #   # or from file
-    #   proxy = ProxyManager::Proxy.new('proxies.txt')
-    # @return [Class] Main object
-    # @see Main
     def initialize(proxies)
       @list = []
 

spec/proxy_manager/proxy_spec.rb

@@ -8,65 +8,53 @@
                                  'support',
                                  'proxies.txt'
                                 ) }
-  let(:proxy) { ProxyManager::Proxy.new(['127.0.0.1:80', '127.0.0.1:8080']) }
+  subject { ProxyManager::Proxy.new(['127.0.0.1:80', '127.0.0.1:8080']) }
 
-  it 'should return list' do
-    expect(proxy.list).to match_array list
-  end
-
-  context '#connectable' do
-    it 'should response' do
-      expect(proxy).to respond_to(:connectable?)
-    end
+  context '#get' do
+    its(:get) { should be_a Array }
 
-    it 'should receive array' do
-      expect(proxy.connectable?(['google.com', 80])).to be_true
+    it 'should return many proxies' do
+      expect { subject.get(3) }.not_to raise_error
     end
+  end
 
-    it 'should receive string' do
-      expect(proxy.connectable?('google.com:80')).to be_true
-    end
+  context '#get!' do
+    it { should respond_to :get! }
   end
 
-  context '#get' do
-    it 'should response' do
-      expect(proxy).to respond_to(:get)
-    end
+  context '#list' do
+    its(:list) { should match_array list }
+  end
 
-    it 'should return array' do
-      expect(proxy.get).to be_a Array
+  context '::connectable' do
+    it 'should receive array' do
+      expect(ProxyManager::Proxy.connectable?(['127.0.0.1', 8080])).to be_false
     end
 
-    it 'should return many proxies' do
-      expect { proxy.get(3) }.not_to raise_error
+    it 'should receive string' do
+      expect(ProxyManager::Proxy.connectable?("127.0.0.1:8080")).to be_false
     end
   end
 
   context 'when load from file' do
-    let(:proxy) { ProxyManager::Proxy.new(proxies_file) }
+    subject { ProxyManager::Proxy.new(proxies_file) }
 
-    it 'should return list' do
-      expect(proxy.list).to match_array list
-    end
+    its(:list) { should match_array list }
 
     context 'and save file' do
-      before { @source = File.read(proxies_file) }
+      let(:source) { IO.read(proxies_file) }
 
       it 'should update proxies source' do
-        proxy.get(2)
+        subject.get(2)
 
         source = ''
-        proxy.list.each_with_index do |p, index|
-          source << "#{p[0]}:#{p[1]}"
-          source << "\n" if proxy.list[index + 1]
-        end
+        subject.list.each { |p| source << "#{p[0]}:#{p[1]}\n" }
+        source.sub!(/\n$/, '')
 
-        expect(File.open(proxies_file, "rb").read).to eq(source)
+        expect(IO.read(proxies_file)).to eq(source)
       end
 
-      after do
-        File.open(proxies_file, 'w').write(@source)
-      end
+      after { IO.write(proxies_file, source) }
     end
   end
 end