add some more hinting

Author: GeoSot

src/Mixins/RelationshipsExtraMethods.php

@@ -34,6 +34,8 @@
  * @method string getQualifiedLocalKeyName()
  * @method string getExistenceCompareKey()
  * @mixin \Illuminate\Database\Eloquent\Relations\Relation
+ * @mixin \Illuminate\Database\Eloquent\Relations\HasOneOrMany
+ * @mixin \Illuminate\Database\Eloquent\Relations\BelongsToMany
  * @property EloquentBuilder $query
  * @property \Illuminate\Database\Eloquent\Model $parent
  * @property \Illuminate\Database\Eloquent\Model $throughParent
@@ -105,7 +107,7 @@ protected function performJoinForEloquentPowerJoinsForBelongsTo(): \Closure
      */
     protected function performJoinForEloquentPowerJoinsForBelongsToMany(): \Closure
     {
-        return function ($builder, $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): static {
+        return function (EloquentBuilder $builder, string $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): static {
             [$alias1, $alias2] = $alias;
 
             $joinedTable = $alias1 ?: $this->getTable();
@@ -161,7 +163,7 @@ protected function performJoinForEloquentPowerJoinsForBelongsToMany(): \Closure
      */
     protected function performJoinForEloquentPowerJoinsForMorphToMany(): \Closure
     {
-        return function ($builder, $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): static {
+        return function (EloquentBuilder $builder, string $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): static {
             [$alias1, $alias2] = $alias;
 
             $joinedTable = $alias1 ?: $this->getTable();
@@ -217,7 +219,7 @@ protected function performJoinForEloquentPowerJoinsForMorphToMany(): \Closure
      */
     protected function performJoinForEloquentPowerJoinsForMorph(): \Closure
     {
-        return function (Builder $builder, $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false) {
+        return function (Builder $builder, string $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false) {
             $builder->{$joinType}($this->getModel()->getTable(), function (PowerJoinClause $join) use ($callback, $disableExtraConditions) {
                 $join->on(
                     "{$this->getModel()->getTable()}.{$this->getForeignKeyName()}",
@@ -247,7 +249,7 @@ protected function performJoinForEloquentPowerJoinsForMorph(): \Closure
      */
     protected function performJoinForEloquentPowerJoinsForMorphTo() :\Closure
     {
-        return function (Builder $builder, $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false, string $morphable = null) {
+        return function (Builder $builder, string $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false, string $morphable = null) {
             $modelInstance = new $morphable;
 
             $builder->{$joinType}($modelInstance->getTable(), function ($join) use ($modelInstance, $callback, $disableExtraConditions) {
@@ -279,7 +281,7 @@ protected function performJoinForEloquentPowerJoinsForMorphTo() :\Closure
      */
     protected function performJoinForEloquentPowerJoinsForHasMany(): \Closure
     {
-        return function ($builder, $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): void {
+        return function (EloquentBuilder $builder, string $joinType, callable $callback = null, $alias = null, bool $disableExtraConditions = false): void {
             $joinedTable = $alias ?: $this->getQuery()->getModel()->getTable();
             $parentTable = StaticCache::getTableOrAliasForModel($this->parent);
             $isOneOfMany = method_exists($this, 'isOneOfMany') ? $this->isOneOfMany() : false;
@@ -325,7 +327,7 @@ protected function performJoinForEloquentPowerJoinsForHasMany(): \Closure
      */
     protected function performJoinForEloquentPowerJoinsForHasManyThrough(): \Closure
     {
-        return function ($builder, $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): static {
+        return function (EloquentBuilder $builder, string $joinType, $callback = null, $alias = null, bool $disableExtraConditions = false): static {
             [$alias1, $alias2] = $alias;
             $throughTable = $alias1 ?: $this->getThroughParent()->getTable();
             $farTable = $alias2 ?: $this->getModel()->getTable();