Add extra condition to avoid wrong on clause on MorphTo joins, closes #191 (#192)

sebj54 · web-flow · commit 3c1af9b86b02 · 2024-11-26T10:22:08.000-03:00
diff --git a/src/Mixins/RelationshipsExtraMethods.php b/src/Mixins/RelationshipsExtraMethods.php
@@ -530,7 +530,7 @@ public function applyNestedCondition()
     public function shouldNotApplyExtraCondition()
     {
         return function ($condition) {
-            if (isset($condition['column']) && Str::endsWith($condition['column'], '.')) {
+            if (isset($condition['column']) && ($condition['column'] === '' || Str::endsWith($condition['column'], '.'))) {
                 return true;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ public function applyNestedCondition()`
`530`	`530`	`public function shouldNotApplyExtraCondition()`
`531`	`531`	`{`
`532`	`532`	`return function ($condition) {`
`533`		`- if (isset($condition['column']) && Str::endsWith($condition['column'], '.')) {`
	`533`	`+ if (isset($condition['column']) && ($condition['column'] === '' \|\| Str::endsWith($condition['column'], '.'))) {`
`534`	`534`	`return true;`
`535`	`535`	`}`
`536`	`536`