Skip to content

A few TestZshGlobalExplicit tests are failing after upgrade to zsh 5.9.0.3 #544

@mgorny

Description

@mgorny

After upgrading zsh to 5.9.0.3, I'm seeing the following test failures:

$ python test/test.py TestZshGlobalExplicit
ss.......ss.FFFF..............
======================================================================
FAIL: test_python_completion (__main__.TestZshGlobalExplicit.test_python_completion)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/argcomplete/test/test.py", line 1348, in test_python_completion
    self.assertEqual(self.sh.run_command("python3 ./prog basic f\t"), "foo\r\n")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: "usage: prog basic [-h] {foo,bar,baz}\r\nprog basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)\r\n" != 'foo\r\n'
+ foo
- usage: prog basic [-h] {foo,bar,baz}
- prog basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)


======================================================================
FAIL: test_python_filename_completion (__main__.TestZshGlobalExplicit.test_python_filename_completion)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/argcomplete/test/test.py", line 1352, in test_python_filename_completion
    self.assertEqual(self.sh.run_command("python3 ./pro\tbasic f\t"), "foo\r\n")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: "usage: prog basic [-h] {foo,bar,baz}\r\nprog basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)\r\n" != 'foo\r\n'
+ foo
- usage: prog basic [-h] {foo,bar,baz}
- prog basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)


======================================================================
FAIL: test_python_module (__main__.TestZshGlobalExplicit.test_python_module)
Test completing a module run with python -m.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/argcomplete/test/test.py", line 1378, in test_python_module
    self.assertEqual(self.sh.run_command("python3 -m package.prog basic f\t"), "foo\r\n")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: "usage: prog.py basic [-h] {foo,bar,baz}\r\nprog.py basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)\r\n" != 'foo\r\n'
+ foo
- usage: prog.py basic [-h] {foo,bar,baz}
- prog.py basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)


======================================================================
FAIL: test_python_not_executable (__main__.TestZshGlobalExplicit.test_python_not_executable)
Test completing a script that cannot be run directly.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/argcomplete/test/test.py", line 1368, in test_python_not_executable
    self.assertEqual(self.sh.run_command("python3 ./prog basic f\t"), "foo\r\n")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: "usage: prog basic [-h] {foo,bar,baz}\r\nprog basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)\r\n" != 'foo\r\n'
+ foo
- usage: prog basic [-h] {foo,bar,baz}
- prog basic: error: argument arg: invalid choice: 'f' (choose from foo, bar, baz)


----------------------------------------------------------------------
Ran 30 tests in 37.798s

FAILED (failures=4, skipped=4)

I can reproduce atop fae5549 (3.6.3), with Python 3.13.9 and 3.11.14. The respective tests pass if I downgrade zsh to 5.9.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions