Polarization bugfix, turned off asserts for badly conditioned polarization vecotors (not sure how to warn about it correctly)

Author: kitchenknif

PyATMM/isotropicTransferMatrix.py

@@ -106,9 +106,16 @@ def isotropic_polarizations(w, eps, kx, ky, kz):
     p = [p_1, p_2, p_3, p_4]
     p = [numpy.divide(pi, numpy.sqrt(numpy.dot(pi, pi))) for pi in p]
 
-    assert numpy.isclose(numpy.dot(p[0], k[0]), 0)
-    assert numpy.isclose(numpy.dot(p[1], k[1]), 0)
-    assert numpy.isclose(numpy.dot(p[2], k[2]), 0)
-    assert numpy.isclose(numpy.dot(p[3], k[3]), 0)
+    if not numpy.isclose(numpy.dot(p[0], k[0]), 0+0j) \
+        or not numpy.isclose(numpy.dot(p[1], k[1]), 0+0j) \
+        or not numpy.isclose(numpy.dot(p[2], k[2]), 0 + 0j) \
+        or not numpy.isclose(numpy.dot(p[3], k[3]), 0 + 0j):
+
+        print("ALYARMA")
+
+    #assert numpy.isclose(numpy.dot(p[0], k[0]), 0+0j)
+    #assert numpy.isclose(numpy.dot(p[1], k[1]), 0+0j)
+    #assert numpy.isclose(numpy.dot(p[2], k[2]), 0+0j)
+    #assert numpy.isclose(numpy.dot(p[3], k[3]), 0+0j)
 
     return p

PyATMM/transferMatrix.py

@@ -178,14 +178,19 @@ def solve_transfer_matrix(M):
     denom = M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0]
     #print(denom)
 
-    r_ss = (M[1, 0]*M[2, 2] - M[1, 2]*M[2, 0]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    r_sp = (M[3, 0]*M[2, 2] - M[3, 2]*M[2, 0]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    r_ps = (M[0, 0]*M[1, 2] - M[1, 0]*M[0, 2]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    r_pp = (M[0, 0]*M[3, 2] - M[3, 0]*M[0, 2]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    t_ss = M[2, 2] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    t_sp = -M[2, 0] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    t_ps = -M[0, 2] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
-    t_pp = M[0, 0] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+
+    #
+    # Components 3,4 - S
+    # Components 1,2 - P Was mixed up until 11.08.2016 (switched s and p)
+    #
+    r_pp = (M[1, 0]*M[2, 2] - M[1, 2]*M[2, 0]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    r_ps = (M[3, 0]*M[2, 2] - M[3, 2]*M[2, 0]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    r_sp = (M[0, 0]*M[1, 2] - M[1, 0]*M[0, 2]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    r_ss = (M[0, 0]*M[3, 2] - M[3, 0]*M[0, 2]) / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    t_pp = M[2, 2] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    t_ps = -M[2, 0] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    t_sp = -M[0, 2] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
+    t_ss = M[0, 0] / (M[0, 0]*M[2, 2] - M[0, 2]*M[2, 0])
 
     return r_ss, r_sp, r_ps, r_pp, t_ss, t_sp, t_ps, t_pp