refactor toasts, add toasts for individual keyword view

Author: jnptk

frontend/packages/volto-keywordmanager/src/components/KeywordManager.tsx

@@ -95,39 +95,6 @@ const KeywordManager = (props) => {
     dispatch(getKeywordIndexes());
   }, [dispatch, options]);
 
-  useEffect(() => {
-    const actionType = keywords.type;
-
-    const isUpdate = actionType.startsWith('UPDATE_');
-    const isDelete = actionType.startsWith('DELETE_');
-    const isSuccess = actionType.endsWith('_SUCCESS');
-    const isFail = actionType.endsWith('_FAIL');
-
-    if (!isUpdate && !isDelete) return;
-
-    if (isUpdate) {
-      isSuccess &&
-        toast.success(
-          <Toast title="Update Success" content="Updated successfully!" />,
-        );
-      isFail &&
-        toast.error(
-          <Toast error title="Update Failed" content="Could not update." />,
-        );
-    }
-
-    if (isDelete) {
-      isSuccess &&
-        toast.success(
-          <Toast title="Delete Success" content="Deleted successfully!" />,
-        );
-      isFail &&
-        toast.error(
-          <Toast error title="Delete Failed" content="Could not delete." />,
-        );
-    }
-  }, [keywords]);
-
   const columns = [
     {
       id: 'keyword',
@@ -204,6 +171,13 @@ const KeywordManager = (props) => {
     setIsLoading(true);
     try {
       await dispatch(deleteKeywords({ items: kw, indexName: keywordIndex }));
+      toast.success(
+        <Toast title="Delete Success" content="Deleted successfully!" />,
+      );
+    } catch (error) {
+      toast.error(
+        <Toast error title="Delete Failed" content="Could not delete." />,
+      );
     } finally {
       setIsLoading(false);
     }
@@ -220,6 +194,13 @@ const KeywordManager = (props) => {
           indexName: keywordIndex,
         }),
       );
+      toast.success(
+        <Toast title="Update Success" content="Updated successfully!" />,
+      );
+    } catch (error) {
+      toast.error(
+        <Toast error title="Update Failed" content="Could not update." />,
+      );
     } finally {
       setIsLoading(false);
     }

frontend/packages/volto-keywordmanager/src/components/KeywordView.tsx

@@ -13,6 +13,8 @@ import { useDispatch, useSelector } from 'react-redux';
 import { Link, useParams } from 'react-router-dom';
 import { deleteKeywords } from 'volto-keywordmanager/actions/keywords';
 import DeleteModal from './DeleteModal';
+import { toast } from 'react-toastify';
+import { Toast } from '@plone/components';
 
 import { getVocabulary } from '@plone/volto/actions/vocabularies/vocabularies';
 import backSVG from '@plone/volto/icons/back.svg';
@@ -131,6 +133,13 @@ const KeywordView = (props) => {
       await dispatch(
         deleteKeywords({ items: kw, path: id, indexName: keywordIndex }),
       );
+      toast.success(
+        <Toast title="Delete Success" content="Deleted successfully!" />,
+      );
+    } catch (error) {
+      toast.error(
+        <Toast error title="Delete Failed" content="Could not delete." />,
+      );
     } finally {
       setIsLoading(false);
     }