Skip to content

Commit bff5a0b

Browse files
committed
fix sorting icon in table header
1 parent b7fd33c commit bff5a0b

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

frontend/packages/volto-keywordmanager/src/components/KeywordManager.tsx

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import type { SortDescriptor, Selection } from 'react-aria-components';
22
import { Table, TableHeader, TableBody } from 'react-aria-components';
33
import { Column, Row, Cell, Collection } from 'react-aria-components';
4-
import { Checkbox } from 'react-aria-components';
5-
import { Spinner, Button, Select } from '@plone/components';
4+
import { Checkbox, Spinner, Button, Select } from '@plone/components';
65
import { DialogTrigger } from '@plone/components';
76
import Toolbar from '@plone/volto/components/manage/Toolbar/Toolbar';
87
import Icon from '@plone/volto/components/theme/Icon/Icon';
@@ -135,7 +134,12 @@ const KeywordManager = (props) => {
135134
name: (
136135
<>
137136
{intl.formatMessage(messages.keyword)}
138-
<Icon name={sortDownSVG} size="16px" ariaHidden="true" />
137+
<Icon
138+
className={sortOn === 'keyword' && 'active'}
139+
name={sortOrder === 'descending' ? sortDownSVG : sortUpSVG}
140+
size="20px"
141+
ariaHidden="true"
142+
/>
139143
</>
140144
),
141145
isRowHeader: true,
@@ -146,7 +150,12 @@ const KeywordManager = (props) => {
146150
name: (
147151
<>
148152
{intl.formatMessage(messages.occurrence)}
149-
<Icon name={sortDownSVG} size="16px" ariaHidden="true" />
153+
<Icon
154+
className={sortOn === 'occurrence' && 'active'}
155+
name={sortOrder === 'descending' ? sortDownSVG : sortUpSVG}
156+
size="20px"
157+
ariaHidden="true"
158+
/>
150159
</>
151160
),
152161
allowsSorting: true,

frontend/packages/volto-keywordmanager/src/theme/main.css

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,14 @@
6666

6767
.react-aria-Column,
6868
.react-aria-Cell {
69-
height: 36px;
7069
padding: 10px;
7170
border: none;
7271

72+
&[role='columnheader'] svg:not(.active) {
73+
opacity: 0.4;
74+
padding-left: 5px;
75+
}
76+
7377
&[role='columnheader'],
7478
&[data-key$=':actions'],
7579
&[data-key$=':type'],
@@ -178,8 +182,7 @@
178182
}
179183

180184
.react-aria-ModalOverlay .rename-modal,
181-
.react-aria-ModalOverlay .delete-modal,
182-
.react-aria-ModalOverlay .keyword-modal {
185+
.react-aria-ModalOverlay .delete-modal {
183186
display: flex;
184187
width: 100%;
185188
max-width: 1070px;

0 commit comments

Comments
 (0)