Add versioning tests for Workspace and Wiki Page content types

Move the Workspace and WikiPage FTI assertions out of the central
test_fti.py table into dedicated per-type test modules, following the
test_subsite.py pattern, and cover the new edit-time versioning:

- tests/content_types/test_workspace.py: new module with FTI, behavior,
  creation and versioning tests.
- tests/content_types/test_wiki_page.py: reuse the shared portal_type /
  container / payload / content_factory fixtures and add versioning
  tests.
- tests/content_types/test_fti.py: drop the entries now covered by the
  per-type modules.

Refs https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/550

Author: ericof

backend/tests/content_types/test_fti.py

@@ -256,68 +256,6 @@ def _setup(self, portal, get_fti):
                     "kitconcept.intranet.content_review",
                 ),
             ),
-            ("Workspace", "title", "Workspace"),
-            ("Workspace", "description", "A folderish workspace container."),
-            ("Workspace", "allow_discussion", False),
-            ("Workspace", "global_allow", True),
-            ("Workspace", "filter_content_types", True),
-            (
-                "Workspace",
-                "allowed_content_types",
-                (
-                    "WikiPage",
-                    "File",
-                    "Image",
-                ),
-            ),
-            (
-                "Workspace",
-                "behaviors",
-                (
-                    "plone.basic",
-                    "volto.preview_image_link",
-                    "plone.categorization",
-                    "plone.publication",
-                    "plone.ownership",
-                    "plone.relateditems",
-                    "plone.shortname",
-                    "volto.navtitle",
-                    "plone.excludefromnavigation",
-                    "plone.allowdiscussion",
-                    "volto.blocks",
-                    "plone.constraintypes",
-                    "plone.namefromtitle",
-                    "plone.versioning",
-                    "plone.locking",
-                    "plone.translatable",
-                    "kitconcept.plate.workspace",
-                    "kitconcept.intranet.clm",
-                ),
-            ),
-            ("WikiPage", "title", "Wiki Page"),
-            (
-                "WikiPage",
-                "behaviors",
-                (
-                    "plone.basic",
-                    "volto.preview_image_link",
-                    "plone.categorization",
-                    "plone.publication",
-                    "plone.ownership",
-                    "plone.relateditems",
-                    "plone.shortname",
-                    "volto.navtitle",
-                    "plone.excludefromnavigation",
-                    "plone.allowdiscussion",
-                    "volto.blocks",
-                    "plone.constraintypes",
-                    "plone.namefromtitle",
-                    "plone.versioning",
-                    "plone.locking",
-                    "plone.translatable",
-                    "kitconcept.intranet.clm",
-                ),
-            ),
             ("Plone Site", "title", "Plone Site"),
             ("Plone Site", "klass", "Products.CMFPlone.Portal.PloneSite"),
             ("Plone Site", "global_allow", False),

backend/tests/content_types/test_wiki_page.py

@@ -1,7 +1,6 @@
 from collections.abc import Generator
 from plone import api
 from plone.api.exc import InvalidParameterError
-from plone.app.testing.interfaces import SITE_OWNER_NAME
 from plone.dexterity.fti import DexterityFTI
 from Products.CMFPlone.Portal import PloneSite
 
@@ -14,13 +13,36 @@ def portal(app_class, create_site, answers) -> Generator[PloneSite]:
     yield site
 
 
-class TestWikiPage:
-    portal_type: str = "WikiPage"
+@pytest.fixture(scope="class")
+def portal_type() -> str:
+    return "WikiPage"
+
+
+@pytest.fixture(scope="class")
+def container(portal, content_factory):
+    """Return the container used to create the content instance under test."""
+    payload = {
+        "type": "Workspace",
+        "id": "my-workspace",
+    }
+    return content_factory(portal, payload)
+
+
+@pytest.fixture(scope="class")
+def payload(portal_type) -> dict:
+    return {
+        "type": portal_type,
+        "id": "my-other-wiki-page",
+        "title": "My other wiki page",
+        "description": "Description of my other wiki page",
+    }
+
 
+class TestWikiPage:
     @pytest.fixture(autouse=True)
-    def _setup(self, portal, get_fti) -> None:
+    def _setup(self, portal, get_fti, portal_type) -> None:
         self.portal = portal
-        self.fti: DexterityFTI = get_fti(self.portal_type)
+        self.fti: DexterityFTI = get_fti(portal_type)
 
     @pytest.mark.parametrize(
         "attr,expected",
@@ -44,8 +66,9 @@ def test_fti(self, attr: str, expected):
         assert isinstance(self.fti, DexterityFTI)
         assert getattr(self.fti, attr) == expected
 
-    def test_behaviors(self):
-        assert self.fti.behaviors == (
+    @pytest.mark.parametrize(
+        "idx,behavior",
+        enumerate((
             "plone.basic",
             "volto.preview_image_link",
             "plone.categorization",
@@ -63,27 +86,43 @@ def test_behaviors(self):
             "plone.locking",
             "plone.translatable",
             "kitconcept.intranet.clm",
-        )
+        )),
+    )
+    def test_behaviors(self, idx, behavior):
+        assert self.fti.behaviors[idx] == behavior
 
-    def test_wikipage_requires_workspace_container(self):
-        with api.env.adopt_user(SITE_OWNER_NAME):
+    def test_wikipage_requires_workspace_container(
+        self, site_owner_name, content_factory, portal_type, payload
+    ):
+        with api.env.adopt_user(site_owner_name):
             with pytest.raises(InvalidParameterError):
-                api.content.create(
-                    container=self.portal,
-                    type=self.portal_type,
-                    title="Root Wiki Page",
-                )
-
-            workspace = api.content.create(
-                container=self.portal,
-                type="Workspace",
-                title="Team Workspace",
-            )
-            page = api.content.create(
-                container=workspace,
-                type=self.portal_type,
-                title="Workspace Wiki Page",
+                content_factory(self.portal, payload)
+
+            workspace = content_factory(
+                self.portal,
+                {"type": "Workspace", "title": "Team Workspace"},
             )
+            page = content_factory(workspace, payload)
 
-        assert page.portal_type == self.portal_type
+        assert page.portal_type == portal_type
         assert page.aq_parent == workspace
+
+    def test_versionable(self, portal_type, versionable_content_types):
+        assert portal_type in versionable_content_types
+
+    def test_create_initial_version_after_adding(self, last_version, content_instance):
+        version = last_version(content_instance)
+        assert version.comment.default == "Initial version"
+        assert version.version_id == 0
+
+    def test_create_version_on_save(
+        self, notify_modified, history, last_version, content_instance
+    ):
+        with api.env.adopt_roles(["Manager"]):
+            content_instance.title = "Wiki Redux"
+            notify_modified(content_instance)
+        history_data = history(content_instance)
+        assert len(history_data) == 2  # Initial + modified version
+        version = last_version(content_instance)
+        assert version.comment is None
+        assert version.version_id == 1

backend/tests/content_types/test_workspace.py

@@ -0,0 +1,102 @@
+from collections.abc import Generator
+from plone import api
+from plone.dexterity.fti import DexterityFTI
+from Products.CMFPlone.Portal import PloneSite
+
+import pytest
+
+
+@pytest.fixture(scope="class")
+def portal(app_class, create_site, answers) -> Generator[PloneSite]:
+    site = create_site(app=app_class, answers=answers)
+    yield site
+
+
+@pytest.fixture(scope="class")
+def portal_type() -> str:
+    return "Workspace"
+
+
+@pytest.fixture(scope="class")
+def payload(portal_type) -> dict:
+    return {
+        "type": portal_type,
+        "id": "my-personal-workspace",
+        "title": "My personal workspace",
+        "description": "Description of my personal workspace",
+    }
+
+
+class TestWorkspace:
+    @pytest.fixture(autouse=True)
+    def _setup(self, portal, get_fti, portal_type) -> None:
+        self.portal = portal
+        self.fti: DexterityFTI = get_fti(portal_type)
+
+    @pytest.mark.parametrize(
+        "attr,expected",
+        [
+            ("title", "Workspace"),
+            ("factory", "Workspace"),
+            ("description", "A folderish workspace container."),
+            ("schema", "kitconcept.plate.content.workspace.IWorkspace"),
+            ("allow_discussion", False),
+            ("global_allow", True),
+            ("filter_content_types", True),
+            ("allowed_content_types", ("WikiPage", "File", "Image")),
+        ],
+    )
+    def test_fti(self, attr: str, expected):
+        assert isinstance(self.fti, DexterityFTI)
+        assert getattr(self.fti, attr) == expected
+
+    @pytest.mark.parametrize(
+        "idx,behavior",
+        (
+            enumerate((
+                "plone.basic",
+                "volto.preview_image_link",
+                "plone.categorization",
+                "plone.publication",
+                "plone.ownership",
+                "plone.relateditems",
+                "plone.shortname",
+                "volto.navtitle",
+                "plone.excludefromnavigation",
+                "plone.allowdiscussion",
+                "volto.blocks",
+                "plone.constraintypes",
+                "plone.namefromtitle",
+                "plone.versioning",
+                "plone.locking",
+                "plone.translatable",
+                "kitconcept.plate.workspace",
+            ))
+        ),
+    )
+    def test_behaviors(self, idx, behavior):
+        assert self.fti.behaviors[idx] == behavior
+
+    def test_workspace_creation(self, content_instance, portal_type):
+        assert content_instance.portal_type == portal_type
+        assert content_instance.aq_parent == self.portal
+
+    def test_versionable(self, portal_type, versionable_content_types):
+        assert portal_type in versionable_content_types
+
+    def test_create_initial_version_after_adding(self, last_version, content_instance):
+        version = last_version(content_instance)
+        assert version.comment.default == "Initial version"
+        assert version.version_id == 0
+
+    def test_create_version_on_save(
+        self, notify_modified, history, last_version, content_instance
+    ):
+        with api.env.adopt_roles(["Manager"]):
+            content_instance.title = "Workspace Redux"
+            notify_modified(content_instance)
+        history_data = history(content_instance)
+        assert len(history_data) == 2  # Initial + modified version
+        version = last_version(content_instance)
+        assert version.comment is None
+        assert version.version_id == 1