Skip to content

add'on configuration for configuration trackers is confusing #34

@fredvd

Description

@fredvd

We've been struggling with configuring volto-dsgvo-banner in a project. The support for matomo seems to have been added later, but which modules can be active is now confusing.

the 'modules' list by default contains 'tracking' and 'google'.

modules: ['tracking', 'youtube', 'facebook', 'google'],

But in the rest of the code, there is no flexible check for these keys in the array, activation of either Google or Matomo is based on config.settings.DSGVOBanner.tracker.type and each analytics subcomponent hardcoded checks for the confirm_tracking cookie.

{config.settings.DSGVOBanner.tracker.type === 'google' && <Google />}
{config.settings.DSGVOBanner.tracker.type === 'matomo' && <Matomo />}

const confirmTracking = !!Number(cookies.confirm_tracking);

'matomo' is missing from the supported modules in the readme:. https://github.com/kitconcept/volto-dsgvo-banner?tab=readme-ov-file#supported-modules . But google still has its own cookie set when it only usess confirm_tracking:

const [confirmGoogle, setConfirmGoogle] = useState(

So there is a strange mix of settings where maybe the idea was to be able to add google and matomo separeately as consent categories in the modal, but the checking is inconsistent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions