We've been struggling with configuring volto-dsgvo-banner in a project. The support for matomo seems to have been added later, but which modules can be active is now confusing.
the 'modules' list by default contains 'tracking' and 'google'.
|
modules: ['tracking', 'youtube', 'facebook', 'google'], |
But in the rest of the code, there is no flexible check for these keys in the array, activation of either Google or Matomo is based on config.settings.DSGVOBanner.tracker.type and each analytics subcomponent hardcoded checks for the confirm_tracking cookie.
|
{config.settings.DSGVOBanner.tracker.type === 'google' && <Google />} |
|
{config.settings.DSGVOBanner.tracker.type === 'matomo' && <Matomo />} |
const confirmTracking = !!Number(cookies.confirm_tracking);
'matomo' is missing from the supported modules in the readme:. https://github.com/kitconcept/volto-dsgvo-banner?tab=readme-ov-file#supported-modules . But google still has its own cookie set when it only usess confirm_tracking:
|
const [confirmGoogle, setConfirmGoogle] = useState( |
So there is a strange mix of settings where maybe the idea was to be able to add google and matomo separeately as consent categories in the modal, but the checking is inconsistent.
We've been struggling with configuring volto-dsgvo-banner in a project. The support for matomo seems to have been added later, but which modules can be active is now confusing.
the 'modules' list by default contains 'tracking' and 'google'.
volto-dsgvo-banner/src/index.js
Line 29 in d15ce58
But in the rest of the code, there is no flexible check for these keys in the array, activation of either Google or Matomo is based on config.settings.DSGVOBanner.tracker.type and each analytics subcomponent hardcoded checks for the confirm_tracking cookie.
volto-dsgvo-banner/src/components/Banner/Banner.jsx
Lines 140 to 141 in d15ce58
const confirmTracking = !!Number(cookies.confirm_tracking);
'matomo' is missing from the supported modules in the readme:. https://github.com/kitconcept/volto-dsgvo-banner?tab=readme-ov-file#supported-modules . But google still has its own cookie set when it only usess confirm_tracking:
volto-dsgvo-banner/src/components/Banner/Banner.jsx
Line 56 in d15ce58
So there is a strange mix of settings where maybe the idea was to be able to add google and matomo separeately as consent categories in the modal, but the checking is inconsistent.