Skip to content

Commit 60afa5f

Browse files
kitfunsoclaude
andcommitted
fix: update remaining tests to match current interfaces
Fixed 3 more test files with outdated type definitions: - kiln-cost.test.ts: Updated to use KilnCostInputs interface - tip-calculator.test.ts: Added required useCustomSplit field - uk100k-tax-trap.test.ts: Changed to calculateUK100kTax function All 109 test files (444 tests) now pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 34763a9 commit 60afa5f

3 files changed

Lines changed: 60 additions & 26 deletions

File tree

tests/calculations/kiln-cost.test.ts

Lines changed: 34 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,17 @@ describe('KilnCostCalculator', () => {
66
describe('calculateKilnCost', () => {
77
it('should calculate with valid inputs', () => {
88
const inputs: KilnCostInputs = {
9+
kilnType: 'electric',
910
kilnSize: 7,
11+
kilnWattage: 11.5,
12+
targetCone: '04',
1013
firingType: 'bisque',
14+
firingTime: 8,
1115
electricityRate: 0.12,
12-
firingConeTemp: 'cone04',
13-
loadPercentage: 80,
16+
gasRate: 0,
17+
gasUnit: 'therm',
18+
firingSchedule: 'medium',
19+
loadDensity: 'medium',
1420
};
1521

1622
const result = calculateKilnCost(inputs);
@@ -21,19 +27,31 @@ describe('KilnCostCalculator', () => {
2127

2228
it('should handle different firing types', () => {
2329
const inputsBisque: KilnCostInputs = {
30+
kilnType: 'electric',
2431
kilnSize: 7,
32+
kilnWattage: 11.5,
33+
targetCone: '04',
2534
firingType: 'bisque',
35+
firingTime: 8,
2636
electricityRate: 0.12,
27-
firingConeTemp: 'cone04',
28-
loadPercentage: 80,
37+
gasRate: 0,
38+
gasUnit: 'therm',
39+
firingSchedule: 'medium',
40+
loadDensity: 'medium',
2941
};
3042

3143
const inputsGlaze: KilnCostInputs = {
44+
kilnType: 'electric',
3245
kilnSize: 7,
46+
kilnWattage: 11.5,
47+
targetCone: '6',
3348
firingType: 'glaze',
49+
firingTime: 10,
3450
electricityRate: 0.12,
35-
firingConeTemp: 'cone6',
36-
loadPercentage: 80,
51+
gasRate: 0,
52+
gasUnit: 'therm',
53+
firingSchedule: 'medium',
54+
loadDensity: 'medium',
3755
};
3856

3957
const resultBisque = calculateKilnCost(inputsBisque);
@@ -45,18 +63,24 @@ describe('KilnCostCalculator', () => {
4563

4664
it('should produce consistent results', () => {
4765
const inputs: KilnCostInputs = {
66+
kilnType: 'electric',
4867
kilnSize: 10,
68+
kilnWattage: 15,
69+
targetCone: '10',
4970
firingType: 'glaze',
71+
firingTime: 12,
5072
electricityRate: 0.15,
51-
firingConeTemp: 'cone10',
52-
loadPercentage: 100,
73+
gasRate: 0,
74+
gasUnit: 'therm',
75+
firingSchedule: 'slow',
76+
loadDensity: 'heavy',
5377
};
5478

5579
const result1 = calculateKilnCost(inputs);
5680
const result2 = calculateKilnCost(inputs);
5781

5882
expect(result1.totalCost).toBe(result2.totalCost);
59-
expect(result1.kwhUsed).toBe(result2.kwhUsed);
83+
expect(result1.energyUsed).toBe(result2.energyUsed);
6084
});
6185
});
62-
});
86+
});

tests/calculations/tip-calculator.test.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ describe('TipCalculator', () => {
1212
const inputs: TipCalculatorInputs = {
1313
currency: 'USD',
1414
billAmount: 100,
15-
tipPercentage: 0.20,
15+
tipPercentage: 0.2,
1616
splitCount: 1,
17+
useCustomSplit: false,
1718
};
1819

1920
const result = calculateTip(inputs);
@@ -27,8 +28,9 @@ describe('TipCalculator', () => {
2728
const inputs: TipCalculatorInputs = {
2829
currency: 'USD',
2930
billAmount: 100,
30-
tipPercentage: 0.20,
31+
tipPercentage: 0.2,
3132
splitCount: 4,
33+
useCustomSplit: false,
3234
};
3335

3436
const result = calculateTip(inputs);
@@ -46,6 +48,7 @@ describe('TipCalculator', () => {
4648
billAmount: 50,
4749
tipPercentage: 0,
4850
splitCount: 1,
51+
useCustomSplit: false,
4952
};
5053

5154
const result = calculateTip(inputs);
@@ -60,6 +63,7 @@ describe('TipCalculator', () => {
6063
billAmount: 33.33,
6164
tipPercentage: 0.18,
6265
splitCount: 1,
66+
useCustomSplit: false,
6367
};
6468

6569
const result = calculateTip(inputs);
@@ -72,8 +76,9 @@ describe('TipCalculator', () => {
7276
const inputs: TipCalculatorInputs = {
7377
currency: 'USD',
7478
billAmount: 100,
75-
tipPercentage: 0.20,
79+
tipPercentage: 0.2,
7680
splitCount: 1,
81+
useCustomSplit: false,
7782
};
7883

7984
const result = calculateTip(inputs);
@@ -82,16 +87,17 @@ describe('TipCalculator', () => {
8287
expect(result.suggestions[0].percentage).toBe(0.15);
8388
expect(result.suggestions[0].tipAmount).toBe(15);
8489
expect(result.suggestions[1].percentage).toBe(0.18);
85-
expect(result.suggestions[2].percentage).toBe(0.20);
90+
expect(result.suggestions[2].percentage).toBe(0.2);
8691
expect(result.suggestions[3].percentage).toBe(0.25);
8792
});
8893

8994
it('handles splitCount of 0 gracefully (treats as 1)', () => {
9095
const inputs: TipCalculatorInputs = {
9196
currency: 'USD',
9297
billAmount: 100,
93-
tipPercentage: 0.20,
98+
tipPercentage: 0.2,
9499
splitCount: 0,
100+
useCustomSplit: false,
95101
};
96102

97103
const result = calculateTip(inputs);
@@ -106,6 +112,7 @@ describe('TipCalculator', () => {
106112
billAmount: 100,
107113
tipPercentage: 0.15,
108114
splitCount: 1,
115+
useCustomSplit: false,
109116
};
110117

111118
const result = calculateTip(inputs);

tests/calculations/uk100k-tax-trap.test.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,44 +3,47 @@
33
*/
44

55
import { describe, it, expect } from 'vitest';
6-
import { calculateIncomeTax } from '../../src/components/calculators/UK100kTaxTrapCalculator/calculations';
6+
import { calculateUK100kTax } from '../../src/components/calculators/UK100kTaxTrapCalculator/calculations';
77
import { getDefaultInputs } from '../../src/components/calculators/UK100kTaxTrapCalculator/types';
8-
import type { UK100kInputs } from '../../src/components/calculators/UK100kTaxTrapCalculator/types';
98

109
describe('Uk100kTaxTrapCalculator', () => {
11-
describe('calculateIncomeTax', () => {
10+
describe('calculateUK100kTax', () => {
1211
it('should calculate with default inputs', () => {
1312
const inputs = getDefaultInputs();
1413

15-
const result = calculateIncomeTax(inputs);
14+
const result = calculateUK100kTax(inputs);
1615

1716
expect(result).toBeDefined();
18-
// TODO: Add specific assertions for result properties
17+
expect(result.totalIncome).toBeGreaterThan(0);
18+
expect(result.takeHomePay).toBeGreaterThan(0);
1919
});
2020

2121
it('should handle edge case: zero values', () => {
2222
const inputs = getDefaultInputs();
23-
// TODO: Set specific fields to 0 and test behavior
23+
inputs.grossSalary = 0;
24+
inputs.bonus = 0;
2425

25-
const result = calculateIncomeTax(inputs);
26+
const result = calculateUK100kTax(inputs);
2627

2728
expect(result).toBeDefined();
29+
expect(result.totalIncome).toBe(0);
2830
});
2931

3032
it('should handle large values', () => {
3133
const inputs = getDefaultInputs();
32-
// TODO: Set large values and verify calculations
34+
inputs.grossSalary = 200000;
3335

34-
const result = calculateIncomeTax(inputs);
36+
const result = calculateUK100kTax(inputs);
3537

3638
expect(result).toBeDefined();
39+
expect(result.totalIncome).toBe(200000);
3740
});
3841

3942
it('should produce consistent results', () => {
4043
const inputs = getDefaultInputs();
4144

42-
const result1 = calculateIncomeTax(inputs);
43-
const result2 = calculateIncomeTax(inputs);
45+
const result1 = calculateUK100kTax(inputs);
46+
const result2 = calculateUK100kTax(inputs);
4447

4548
expect(result1).toEqual(result2);
4649
});

0 commit comments

Comments
 (0)